DESCRIPTION

TMF: Support for Lttng 2.2

Change-Id: Ib87e9e5598f8b7caad42b1e780f8cddb8aeee4d2
Signed-off-by: Kelsie Blackwell xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2013-07-02 18:27:29.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/2822/

-------------------------------------
author: Brenden Conley
date: 2013-07-02 18:45:31.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/2822/ : SUCCESS

-------------------------------------
author: Braxton Mccarthy
date: 2013-07-02 19:44:55.000000000

Patch Set 1: Code-Review-1

(1 comment)

One very small comment.

I haven't tried it yet, but was it tested for it to not break connectivity to 2.1.x tracers?

Line:595, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/service/LTTngControlService.java -> space before ( and after last )   (you can ctrl+shift+f to get it right)

-------------------------------------
author: Ricky Reeves
date: 2013-07-03 13:51:46.000000000

Patch Set 1: Code-Review-1

(7 comments)

Good work. I tried it with LTTng Tools 2.2 and seems to be ok.

Some other comments:
- Please also add test cases in 
org.eclipse.linuxtools.lttng2.core.tests and org.eclipse.linuxtools.lttng2.ui.tests
- Please also update the LTTng User Guide (update file org.eclipse.linuxtools.lttng.help/doc/User-Guide.mediawiki)

Line:7, /COMMIT_MSG -> change to "LTTng: Support for LTTng Tools 2.2"

Line:257, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/EnableChannelDialog.java -> These changes are only applicable in LTTng Tools 2.2 and not for older versions. Therefore you need to add some logic to only show these fields for LTTng Tools 2.2 and not for 2.1 and 2.0. See CreateSessionDialog for an example. In there I only show the advanced parameters for streaming when the tracer is version 2.1 and higher. Another example is in EnableUstEventsComposite.java where filter option only show-up if it is versin 2.1 and higher.

Line:597, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/service/LTTngControlService.java -> Make sure that OPTION_PER_UID_BUFFERS is only added for tracer version 2.2 and higher

Line:602, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/service/LTTngControlService.java -> only append OPTION_MAX_SIZE_TRACE_FILES for tracer version 2.2 and higher

Line:604, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/service/LTTngControlService.java -> only append OPTION_MAX_TRACE_FILES for tracer version 2.2 and higher

Line:224, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/service/LTTngControlServiceConstants.java -> remove --version because we don't implement it since it is not needed

Line:228, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/service/LTTngControlServiceConstants.java -> remove option OPTION_UST_PREFIX because not needed

-------------------------------------
author: Gerrit Code Review
date: 2013-07-30 14:21:01.000000000

The change could not be merged due to a path conflict.

Please rebase the change locally and upload the rebased commit for review.

-------------------------------------
