DESCRIPTION

Ctf: Callsite bug fix when position is negative (binarySearch)

Change-Id: Id1fdb06c717299f7b0fa8ad0576485d35003ce2b
Signed-off-by: Kelsie Blackwell xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2013-06-27 15:55:18.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/2787/

-------------------------------------
author: Brenden Conley
date: 2013-06-27 16:10:06.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/2787/ : SUCCESS

-------------------------------------
author: Braxton Mccarthy
date: 2013-06-27 16:15:41.000000000

Patch Set 1: Code-Review-1

(7 comments)

We'll also probably get Sonar warnings for using TreeSet instead of Set. But I would leave it like that anyway, TreeSet is so much more useful, with its .floor(), ceiling() etc. methods.

Line:2, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/CTFCallsiteComparator.java -> "2013" only

Line:11, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/CTFCallsiteComparator.java -> Remove extra line

Line:14, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/CTFCallsiteComparator.java -> If this file does not need to be used by external plugins, it could be moved to linuxtools.internal.ctf.core.event

Line:26, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/CTFCallsiteComparator.java -> "private static final" please. Sonar will complain ;)

Line:865, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFTrace.java -> This xxx@xxx.xxx 3.0.  Make sure your baseline is set up correctly, you should get this error.

Also update the javadoc to not say "list" but "set".

Line:148, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFTrace.java -> keep the empty line after

Line:910, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFTrace.java -> ctrl+shift+f

-------------------------------------
