DESCRIPTION

[WIP] tmf: Add state system doc to the user guide

Still missing the query code examples.

Change-Id: Iaac27b3d60c71a14c416388cb782c4fcecc610d4
Signed-off-by: Braxton Mccarthy xxx@xxx.xxx


COMMENTS

author: Braxton Mccarthy
date: 2013-06-03 23:04:04.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2013-06-03 23:04:10.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/2610/ 

-------------------------------------
author: Brenden Conley
date: 2013-06-03 23:18:03.000000000

Patch Set 3: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/2610/ : SUCCESS

-------------------------------------
author: Ricky Reeves
date: 2013-06-04 14:24:04.000000000

Patch Set 3: I would prefer that you didn't submit this

(11 inline comments)



Line:1372, lttng/org.eclipse.linuxtools.tmf.help/doc/User-Guide.mediawiki -> General comment: You should mention that timestamps are long values.

Line:1393, lttng/org.eclipse.linuxtools.tmf.help/doc/User-Guide.mediawiki -> -> only its fd (5) is known

Line:1438, lttng/org.eclipse.linuxtools.tmf.help/doc/User-Guide.mediawiki -> change to interested

Line:1445, lttng/org.eclipse.linuxtools.tmf.help/doc/User-Guide.mediawiki -> they are instead of there are

Line:1531, lttng/org.eclipse.linuxtools.tmf.help/doc/User-Guide.mediawiki -> Sorry the first sentence of section is not clear for me... What is the end of the state system? And what is the other end?

Line:1561, lttng/org.eclipse.linuxtools.tmf.help/doc/User-Guide.mediawiki -> You should mention that the events need to be in chronological order

Line:1565, lttng/org.eclipse.linuxtools.tmf.help/doc/User-Guide.mediawiki -> change to: it is possible

Line:1582, lttng/org.eclipse.linuxtools.tmf.help/doc/User-Guide.mediawiki -> maybe add at the end: for one given timestamp.

Line:1609, lttng/org.eclipse.linuxtools.tmf.help/doc/User-Guide.mediawiki -> use the real name of the package instead of the abbreviated one

Line:1634, lttng/org.eclipse.linuxtools.tmf.help/doc/User-Guide.mediawiki -> change: ... have to pass the state provider as parameter ...

Line:1722, lttng/org.eclipse.linuxtools.tmf.help/doc/User-Guide.mediawiki -> there is a word(s) missing: It is normally reserved for ?  the should

-------------------------------------
author: Braxton Mccarthy
date: 2013-06-04 16:56:38.000000000

Patch Set 3: (2 inline comments)



Line:1372, lttng/org.eclipse.linuxtools.tmf.help/doc/User-Guide.mediawiki -> Ok, will do so in the section about state changes, this is the first place where we mention timetamps.

Line:1634, lttng/org.eclipse.linuxtools.tmf.help/doc/User-Guide.mediawiki -> I'd have to change it to

You have to pass the state provider you want to use, which you should have defined already, in parameter.

Not sure it's really better?

-------------------------------------
author: Gerrit Code Review
date: 2013-06-04 20:52:48.000000000

Your change could not be merged due to a path conflict.

Please merge (or rebase) the change locally and upload the resolution for review.

-------------------------------------
