DESCRIPTION

tmf: nexus lite trace format

This will show an example trace reader

Signed-off-by: Ivy Mitchell xxx@xxx.xxx
Change-Id: I4f9bf7fe0cf1f4453c77d7be6530a1d71cedbbed


COMMENTS

author: Ivy Mitchell
date: 2014-06-06 16:54:38.000000000

Uploaded patch set 4.

-------------------------------------
author: Brenden Conley
date: 2014-06-06 16:54:43.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7312/

-------------------------------------
author: Brenden Conley
date: 2014-06-06 17:41:11.000000000

Patch Set 4: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/7312/ : SUCCESS

-------------------------------------
author: Annalise Jimenez
date: 2014-06-12 13:08:34.000000000

Patch Set 4: Code-Review-1

(17 comments)

A few comments, I haven't tried it yet. What is this example really supposed to show? "example trace reader", yes but there already are a few trace readers in the code. Binary trace reader of a simple (non-ctf) file maybe?

Line:2, lttng/org.eclipse.linuxtools.tracing.examples/src/org/eclipse/linuxtools/tracing/examples/test/trace/nexus/headless/NexusTest.java -> 2014 only

Line:23, lttng/org.eclipse.linuxtools.tracing.examples/src/org/eclipse/linuxtools/tracing/examples/test/trace/nexus/headless/NexusTest.java -> Really?

Line:36, lttng/org.eclipse.linuxtools.tracing.examples/src/org/eclipse/linuxtools/tracing/examples/test/trace/nexus/headless/NexusTest.java -> mmm, that path won't be found on my machine unfortunately...

Line:85, lttng/org.eclipse.linuxtools.tracing.examples/src/org/eclipse/linuxtools/tracing/examples/test/trace/nexus/headless/NexusTest.java -> You should probably add a trace.dispose() here before the next loop.

Line:92, lttng/org.eclipse.linuxtools.tracing.examples/src/org/eclipse/linuxtools/tracing/examples/test/trace/nexus/headless/NexusTest.java -> And wait for whatever performance test strategy we end up using... but that can be changed later.

Line:2, lttng/org.eclipse.linuxtools.tracing.examples/src/org/eclipse/linuxtools/tracing/examples/test/trace/nexus/headless/MakeMeANexus.java -> 2014 only

Line:21, lttng/org.eclipse.linuxtools.tracing.examples/src/org/eclipse/linuxtools/tracing/examples/test/trace/nexus/headless/MakeMeANexus.java -> If this is meant to be an example, a little more documentation would be more than welcome.

Line:25, lttng/org.eclipse.linuxtools.tracing.examples/src/org/eclipse/linuxtools/tracing/examples/test/trace/nexus/headless/MakeMeANexus.java -> It would look better with an empty line here

Line:37, lttng/org.eclipse.linuxtools.tracing.examples/src/org/eclipse/linuxtools/tracing/examples/test/trace/nexus/headless/MakeMeANexus.java -> Could you describe in a sentence or 2 what you are doing here, for the sake of the example reader ;-)

Line:41, lttng/org.eclipse.linuxtools.tracing.examples/src/org/eclipse/linuxtools/tracing/examples/test/trace/nexus/headless/MakeMeANexus.java -> That could be a default location but it could be set in the args as well. 

Or better, you could provide a default example nexus trace with this. Since this is meant as an example, it would be legitimate to have a default file and not require the interested experimenter to run this before.

Line:67, lttng/org.eclipse.linuxtools.tracing.examples/src/org/eclipse/linuxtools/tracing/examples/test/trace/nexus/headless/MakeMeANexus.java -> Exception should be handled explicitly

Line:2, lttng/org.eclipse.linuxtools.tracing.examples/src/org/eclipse/linuxtools/tracing/examples/trace/nexus/NexusTrace.java -> 2014

Line:50, lttng/org.eclipse.linuxtools.tracing.examples/src/org/eclipse/linuxtools/tracing/examples/trace/nexus/NexusTrace.java -> It will have to be rebased after 3.0 release

Line:87, lttng/org.eclipse.linuxtools.tracing.examples/src/org/eclipse/linuxtools/tracing/examples/trace/nexus/NexusTrace.java -> what is 21? 42/2?

Line:88, lttng/org.eclipse.linuxtools.tracing.examples/src/org/eclipse/linuxtools/tracing/examples/trace/nexus/NexusTrace.java -> This should be extracted to a constant

Line:185, lttng/org.eclipse.linuxtools.tracing.examples/src/org/eclipse/linuxtools/tracing/examples/trace/nexus/NexusTrace.java -> Multi-line comments look better inside /** */

Line:191, lttng/org.eclipse.linuxtools.tracing.examples/src/org/eclipse/linuxtools/tracing/examples/trace/nexus/NexusTrace.java -> -6 should be extracted to a constant

-------------------------------------
author: Erick Ross
date: 2015-03-06 20:59:54.000000000

Abandoned

Lttng module is separate project now. Consider submitting your patch to
https://projects.eclipse.org/projects/tools.tracecompass .

-------------------------------------
