DESCRIPTION

tmf: fix bug when importing and no project is selected

Also fix importing custom text and xml traces

Change-Id: I70a13fdfd800bc46475040e6d73a86e19a6bbdc2
Signed-off-by: Ivy Mitchell xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2013-05-28 17:20:50.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/2499/ 

-------------------------------------
author: Brenden Conley
date: 2013-05-28 17:31:56.000000000

Patch Set 1: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/2499/ : SUCCESS

-------------------------------------
author: Braxton Mccarthy
date: 2013-05-28 18:40:12.000000000

Patch Set 1: I would prefer that you didn't submit this

(5 inline comments)

Make sure you don't introduce warnings before pushing.

Line:18, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/importtrace/ImportTraceWizardPageOptions.java -> unused import (discouraged one on top of that!)

Line:31, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/importtrace/ImportTraceWizardPageOptions.java -> This can be easily confused with java.util.List... If it was me I wouldn't import it, and use "org.eclipse.swt.widgets.List" in the file (it's used in 2 places). But I don't mind either way.

Line:55, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/importtrace/ImportTraceWizardPageOptions.java -> extra line

Line:91, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/importtrace/ImportTraceWizardPageOptions.java -> private too

Line:265, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/importtrace/BatchImportTraceWizard.java -> this is bad...

-------------------------------------
