DESCRIPTION

tmf: fix batch import for copying files and reading custom Text traces

Signed-off-by: Ivy Mitchell xxx@xxx.xxx

Change-Id: Ica634ebc4ab10761111e77b3a2eb819bc6c1b5c9


COMMENTS

author: Ivy Mitchell
date: 2013-05-23 18:58:16.000000000

Uploaded patch set 4.

-------------------------------------
author: Brenden Conley
date: 2013-05-23 19:26:11.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/2425/ 

-------------------------------------
author: Brenden Conley
date: 2013-05-23 19:46:44.000000000

Patch Set 4: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/2425/ : SUCCESS

-------------------------------------
author: Braxton Mccarthy
date: 2013-05-23 22:45:23.000000000

Patch Set 4: I would prefer that you didn't submit this

(6 inline comments)



Line:9, /COMMIT_MSG -> Something happened here...

Should be
  Changed-Id ...
  Signed-off-by ...

So that everything is part of the same paragraph and will get parsed by gerrit when we push it.

Line:238, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceType.java -> You can use ':' instead so no need for NLS comment

Line:289, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceType.java -> here too

Line:295, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceType.java -> here too

Line:344, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/importtrace/BatchImportTraceWizard.java -> You can use ':' and avoid the NON-NLS comment

Line:347, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/importtrace/BatchImportTraceWizard.java -> here too

-------------------------------------
author: Ivy Mitchell
date: 2013-05-24 21:52:40.000000000

Patch Set 4: Abandoned

merged into 12958

-------------------------------------
