DESCRIPTION

Tmf: externalize a string

Signed-off-by: Ivy Mitchell xxx@xxx.xxx
Change-Id: Ie7b3caca1d25d4ec44fddd205f3a9646000228dd


COMMENTS

author: Ivy Mitchell
date: 2013-05-23 18:58:16.000000000

Uploaded patch set 5.

-------------------------------------
author: Brenden Conley
date: 2013-05-23 19:18:51.000000000

Patch Set 5:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/2423/ 

-------------------------------------
author: Brenden Conley
date: 2013-05-23 19:37:46.000000000

Patch Set 5: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/2423/ : SUCCESS

-------------------------------------
author: Braxton Mccarthy
date: 2013-05-23 22:53:51.000000000

Patch Set 5: I would prefer that you didn't submit this

(3 inline comments)



Line:7, /COMMIT_MSG -> .
  externalize a string in the BatchImportTraceWizard
would be more descriptive

Line:46, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/importtrace/Messages.java -> could remove this empty line. Also try using a name without _ in it.

Line:336, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/importtrace/BatchImportTraceWizard.java -> You can use ' ' to avoid the NON-NLS comment.

-------------------------------------
author: Ivy Mitchell
date: 2013-05-24 19:17:11.000000000

Patch Set 5: (1 inline comment)

responding to explain my changes

Line:46, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/importtrace/Messages.java -> I want to keep the underscores, it makes the code much more legible.

-------------------------------------
