DESCRIPTION

tmf: Bug fixes for batch import

Remove non-standard non-modal wizard.
Add cancelability to the directory add.

Change-Id: Idedbcd2e5e98a161fcc9ed7e8d086ec11af951f6
Signed-off-by: Ivy Mitchell xxx@xxx.xxx


COMMENTS

author: Ivy Mitchell
date: 2013-05-22 22:11:23.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2013-05-22 22:11:29.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/2395/ 

-------------------------------------
author: Brenden Conley
date: 2013-05-22 22:28:44.000000000

Patch Set 2: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/2395/ : SUCCESS

-------------------------------------
author: Ricky Reeves
date: 2013-05-23 15:47:22.000000000

Patch Set 2: Verified; Looks good to me, but someone else must approve; IP review completed



-------------------------------------
author: Braxton Mccarthy
date: 2013-05-24 15:57:23.000000000

Patch Set 2: I would prefer that you didn't submit this

(6 inline comments)



Line:73, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/importtrace/ImportTraceWizardScanPage.java -> Does this need to be a field? It could be defined in the method, it's only used there.

If it's to be a field, it should be private.

Line:169, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/importtrace/ImportTraceWizardScanPage.java -> Please handle these exceptions, like logging or something.

Line:140, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/importtrace/BatchImportTraceWizard.java -> "magic numbers" should be defined as constants, like DEFAULT_WINDOW_WIDTH and DEFAULT_WINDOW_HEIGHT

Line:154, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/importtrace/BatchImportTraceWizard.java -> You can use ' '

Line:185, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/importtrace/BatchImportTraceWizard.java -> empty if?

Line:540, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/importtrace/BatchImportTraceWizard.java -> If you're just iterating on this, does it need to be put in an array? It could remain a Set (From fParentFiles.keySet())

-------------------------------------
