DESCRIPTION

lttng ui: Fix minor sonar warnings

Mainly fixes the ordering of modifiers, removes commented-out code
and change class with constants to an interface.

Change-Id: I6c5b6d7698c92640b4661720e190b77d7c3a7787
Signed-off-by: Ricky Reeves <Meredith xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2013-05-16 15:58:11.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/2332/ 

-------------------------------------
author: Brenden Conley
date: 2013-05-16 16:19:22.000000000

Patch Set 1: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/2332/ : SUCCESS

-------------------------------------
author: Kaeden Tapia
date: 2013-05-16 17:43:19.000000000

Patch Set 1: Looks good to me, but someone else must approve



-------------------------------------
author: Braxton Mccarthy
date: 2013-05-16 18:54:22.000000000

Patch Set 1: I would prefer that you didn't submit this

(3 inline comments)

very minor stuff

Line:115, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/service/LTTngControlService.java -> should be protected?

Line:131, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/handlers/BaseEnableEventHandler.java -> This method was not public before. Is it intended to make it public?

Line:601, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/EnableUstEventsComposite.java -> one extra indent space

-------------------------------------
author: Ricky Reeves
date: 2013-05-16 19:11:50.000000000

Patch Set 1: (3 inline comments)



Line:115, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/service/LTTngControlService.java -> Done

Line:131, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/handlers/BaseEnableEventHandler.java -> yes it make sense to have it public. It was an initial mistake

Line:601, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/EnableUstEventsComposite.java -> Done

-------------------------------------
