DESCRIPTION

tmf : Show environment variable in the properties view

Fixes bug 407756

Change-Id: Ie90a3094ea8adc335a82182127d7bc0e3b727616
Signed-off-by: David Higgins


COMMENTS

author: Liana Berg
date: 2013-05-23 18:19:43.000000000

Uploaded patch set 5.

-------------------------------------
author: Brenden Conley
date: 2013-05-23 18:19:49.000000000

Patch Set 5:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/2414/ 

-------------------------------------
author: Brenden Conley
date: 2013-05-23 18:35:15.000000000

Patch Set 5: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/2414/ : SUCCESS

-------------------------------------
author: Luciana Barry
date: 2013-05-23 20:21:39.000000000

Patch Set 5: I would prefer that you didn't submit this

(9 inline comments)



Line:309, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/trace/TmfTraceManager.java -> This method should go in the 'Public utility methods' section. Update to javadoc: 'get' should be 'Get' and 'trace' should be 'traces' (two places)

Line:418, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceElement.java -> Get

Line:425, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceElement.java -> Don't use fTrace, f prefix is for member variables.
You could support the trace properties of traces opened in an experiment by adding an inner loop for traces in getTraceSet(openedTrace)...

Line:426, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceElement.java -> ... but here you would instead have to compare with this.getElementUnderTraceFolder().getResource()

Line:438, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceElement.java -> Suggest to rename it traceProperties

Line:440, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceElement.java -> spaces around +

Line:441, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceElement.java -> space after =

Line:448, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceElement.java -> space before ( and around <

Line:451, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceElement.java -> There is a possible clash with the id of properties from this class and the id of traceProperties (which could be anything). Perhaps the id should have a prefix added (and therefore no longer equal to the displayName).

-------------------------------------
