DESCRIPTION

tmf : Show environment variable in the properties view

Fixes bug 407756

Change-Id: Ie90a3094ea8adc335a82182127d7bc0e3b727616
Signed-off-by: Jean-Christian KouamÃ©
xxx@xxx.xxx


COMMENTS

author: Liana Berg
date: 2013-05-21 14:31:43.000000000

Uploaded patch set 4.

-------------------------------------
author: Brenden Conley
date: 2013-05-21 14:31:48.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/2371/ 

-------------------------------------
author: Brenden Conley
date: 2013-05-21 14:49:42.000000000

Patch Set 4: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/2371/ : SUCCESS

-------------------------------------
author: Braxton Mccarthy
date: 2013-05-22 01:05:42.000000000

Patch Set 4: I would prefer that you didn't submit this

(10 inline comments)

Typo/style comments. The commit message ones are important though.

Line:7, /COMMIT_MSG -> variables

Line:12, /COMMIT_MSG -> Unicode problems?

Line:13, /COMMIT_MSG -> Try amending the commit with command-line git, the email address really has to be on the same line.

Line:305, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/trace/TmfTraceManager.java -> Get the currently-opened traces and return them into an unmodifiable set.

Line:14, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceElement.java -> You can add your name here, stating you added support for ITmfTraceProperties

Line:418, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceElement.java -> Get

"in an editor" (there can be more than one open).

Line:420, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceElement.java -> and

Line:424, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceElement.java -> { on the same line

Line:440, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceElement.java -> could be declared as List, but doesn't really matter

Line:446, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceElement.java -> I'm not a big fan of this back-and-forth conversion from [] to Collection to [] again... oh well.

-------------------------------------
