DESCRIPTION

Tmf: improve trace import validation in GDB traces and externalize strings

Change-Id: Id5f9bb30d6b617543a5feef8418509f19c6d8da3


COMMENTS

author: Brenden Conley
date: 2013-05-10 17:59:11.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/2261/ 

-------------------------------------
author: Luciana Barry
date: 2013-05-10 18:06:15.000000000

Patch Set 1: Looks good to me, approved; IP review completed



-------------------------------------
author: Braxton Mccarthy
date: 2013-05-10 18:09:45.000000000

Patch Set 1: Do not submit

(4 inline comments)



Line:9, /COMMIT_MSG -> sign-off

Line:26, lttng/org.eclipse.linuxtools.gdbtrace.core/src/org/eclipse/linuxtools/internal/gdbtrace/core/trace/Messages.java -> Missing Javadoc for the added variables (gives warnings!)

Line:85, lttng/org.eclipse.linuxtools.gdbtrace.core/src/org/eclipse/linuxtools/internal/gdbtrace/core/trace/GdbTrace.java -> extra space

Line:89, lttng/org.eclipse.linuxtools.gdbtrace.core/src/org/eclipse/linuxtools/internal/gdbtrace/core/trace/GdbTrace.java -> please split on 2 lines

-------------------------------------
author: Brenden Conley
date: 2013-05-10 18:22:52.000000000

Patch Set 1: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/2261/ : SUCCESS

-------------------------------------
