DESCRIPTION

valgrind: empty fail() in tests are bad.

In case it fail you have no idea why it failed from the junit logs. 
Replaced a number of them with asserts with messages so the reasong for
the failure is logged.

Change-Id: I6d3dc6773f43ebfac910dbdacbffdb0903a69f1f


COMMENTS

author: Brenden Conley
date: 2013-05-10 14:58:56.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/2256/ 

-------------------------------------
author: Brenden Conley
date: 2013-05-10 15:22:46.000000000

Patch Set 2: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/2256/ : SUCCESS

-------------------------------------
author: Octavio Lucero
date: 2013-05-10 16:30:52.000000000

Patch Set 2: Verified; Looks good to me, approved; IP review completed

Tests pass locally with this change. Makes sense to improve error logging of failing tests, approved.

-------------------------------------
