DESCRIPTION

valgrind: empty fail() in tests are bad.

In case it fail you have no idea why it failed from the junit logs. 
Replaced a number of them with asserts with messages so the reasong for
the failure is logged.

Change-Id: I6d3dc6773f43ebfac910dbdacbffdb0903a69f1f


COMMENTS

author: Brenden Conley
date: 2013-05-10 14:24:57.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/2254/ 

-------------------------------------
author: Brenden Conley
date: 2013-05-10 14:37:09.000000000

Patch Set 1: Fails

Build Failed 

https://hudson.eclipse.org/sandbox/job/linuxtools/2254/ : FAILURE

-------------------------------------
author: Nathanael Holden
date: 2013-05-10 14:58:50.000000000

Patch Set 1: Rebased

-------------------------------------
