DESCRIPTION

Add timezones to preference page


Change-Id: I88281ba937889b816d846ac60a1e7c46d04ff34e
Signed-off-by: Ivy Mitchell xxx@xxx.xxx
Signed-off-by: Alivia Ritter xxx@xxx.xxx

COMMENTS

author: Kaeden Tapia
date: 2013-07-04 19:09:47.000000000

Uploaded patch set 6.

-------------------------------------
author: Brenden Conley
date: 2013-07-04 19:09:52.000000000

Patch Set 6:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/2844/

-------------------------------------
author: Brenden Conley
date: 2013-07-04 19:26:00.000000000

Patch Set 6: Verified+1

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/2844/ : SUCCESS

-------------------------------------
author: Ivy Mitchell
date: 2013-07-17 14:27:23.000000000

Patch Set 6: Verified+1 Code-Review+1 IP-Clean+1

verified, looks great, let's push it! need a 2nd +1

-------------------------------------
author: Braxton Mccarthy
date: 2013-07-17 16:04:19.000000000

Patch Set 6: Code-Review-1

(10 comments)

Line:33, lttng/org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/event/AllTests.java -> could you put them alphabetically in the list, so they are in the same order as the package list

Line:11, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/internal/tmf/core/TmfCorePreferenceInitializer.java -> leave an empty line after the coypright header

Line:11, lttng/org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/event/TmfTimePreferencesTest.java -> empty line

Line:28, lttng/org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/event/TmfTimePreferencesTest.java -> one-line description of tests is always good

Line:33, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/timestamp/TmfTimePreferences.java -> this warning shouldn't be suppressed here.

Perhaps it'd be better to put all the static final Strings in a separate interface, in which you could suppress both javadoc and NLS warnings.

Line:130, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/timestamp/TmfTimePreferences.java -> Missing description, can be the "Return the timestamp pattern" (just so the cell isn't empty in the Javadoc HTML).

Line:137, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/timestamp/TmfTimePreferences.java -> here too

Line:188, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/timestamp/TmfTimePreferences.java -> Could it be
  TIME_ELAPSED_FMT + '.' + ssecFmt;
just in case we change the defines at some point.

Line:30, lttng/org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/event/TmfTimestampFormatTest.java -> aww, a one-line descriptions of tests is always useful!

Line:90, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/widgets/Utils.java -> "public static", Sonar will complain :P
Also needs some proper javadoc

-------------------------------------
author: Kaeden Tapia
date: 2013-07-17 19:16:59.000000000

Patch Set 6:

(10 comments)

Line:33, lttng/org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/event/AllTests.java -> Done. Lame, JDT doesn't have Sort Lines.

Line:11, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/internal/tmf/core/TmfCorePreferenceInitializer.java -> Done

Line:11, lttng/org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/event/TmfTimePreferencesTest.java -> Done

Line:28, lttng/org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/event/TmfTimePreferencesTest.java -> Done

Line:33, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/timestamp/TmfTimePreferences.java -> Done

Line:130, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/timestamp/TmfTimePreferences.java -> Done

Line:137, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/timestamp/TmfTimePreferences.java -> Done

Line:188, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/timestamp/TmfTimePreferences.java -> Done

Line:30, lttng/org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/event/TmfTimestampFormatTest.java -> Done

Line:90, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/widgets/Utils.java -> Done

-------------------------------------
author: Gerrit Code Review
date: 2013-07-22 20:00:57.000000000

The change could not be merged due to a path conflict.

Please rebase the change locally and upload the rebased commit for review.

-------------------------------------
