DESCRIPTION

Add timezones to preference page


Change-Id: I88281ba937889b816d846ac60a1e7c46d04ff34e
Signed-off-by: Ivy Mitchell xxx@xxx.xxx
Signed-off-by: Alivia Ritter xxx@xxx.xxx

COMMENTS

author: Kaeden Tapia
date: 2013-06-28 22:36:26.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2013-06-28 22:36:32.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/2818/

-------------------------------------
author: Brenden Conley
date: 2013-06-28 22:50:16.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/2818/ : SUCCESS

-------------------------------------
author: Ricky Reeves
date: 2013-07-02 18:12:53.000000000

Patch Set 3: Code-Review-1

(5 comments)

Line:231, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/timestamp/TmfTimePreferences.java -> if ssecFmt.equals(SUBSEC_NO_FMT) (empty string) then there is a . at the end. This can only happens in tests, but we should fix it.
Change it to e.g. 
return dateFmt + timeFmt + (ssecFmt.equals(SUBSEC_NO_FMT) ? "" : '.' + ssecFmt); //$NON-NLS-1$;

File Comment: lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/internal/tmf/core/TmfCorePreferenceInitializer.java -> Missing Copyright header

Line:107, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/widgets/TimeGraphScale.java -> TmfSignalManager.register(this); is missing

Line:580, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/widgets/TimeGraphScale.java -> use spaces instead tab

Line:581, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/widgets/TimeGraphScale.java -> use space instead of tab

-------------------------------------
author: Gerrit Code Review
date: 2013-07-22 20:00:57.000000000

The change could not be merged due to a path conflict.

Please rebase the change locally and upload the rebased commit for review.

-------------------------------------
