DESCRIPTION

Bug 391055 - ctf: Read and display custom event attributes

Change-Id: Ie4a1b672201dbcec9e9b147348844a8d18ea7789
Signed-off-by: Kelsie Blackwell xxx@xxx.xxx


COMMENTS

author: Braxton Mccarthy
date: 2013-05-09 19:48:36.000000000

Uploaded patch set 5.

-------------------------------------
author: Brenden Conley
date: 2013-05-09 19:48:41.000000000

Patch Set 5:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/2242/ 

-------------------------------------
author: Braxton Mccarthy
date: 2013-05-09 19:48:58.000000000

Patch Set 5:

Some small style updates

-------------------------------------
author: Braxton Mccarthy
date: 2013-05-09 19:54:30.000000000

Patch Set 5: (1 inline comment)

One last remaining comment, sorry for not picking it up the first time.

Line:290, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/event/TmfEventPropertySource.java -> Should check that .listCustomAttributes() is not null before calling .isEmpty() on it. The Javadoc does specify "it should not be null", but there is no compile-time safety (yet).

At this point it might become clearer to do something like:

  if (instanceof ITmfCustomAtributes) {
    ITmfCustomAttributes ev = (ITmfCustomAttributes) fEvent;
    if (ev.listCustomAttributes != null && !ev.listCustomAttributes().isEmpty()) {
      descriptors.add...
    }
  }

-------------------------------------
author: Braxton Mccarthy
date: 2013-05-09 19:54:50.000000000

Patch Set 5: I would prefer that you didn't submit this



-------------------------------------
author: Brenden Conley
date: 2013-05-09 20:04:44.000000000

Patch Set 5: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/2242/ : SUCCESS

-------------------------------------
