DESCRIPTION

Valgrind: Add support for --soname-synonyms flag in valgrind 3.8

Change-Id: If4642384c06f4779bad20be5c1fc5f378fc042cc


COMMENTS

author: Gerrit Code Review
date: 2013-09-11 14:45:24.000000000

The change could not be merged due to a path conflict.

Please rebase the change locally and upload the rebased commit for review.

-------------------------------------
author: Brenden Conley
date: 2013-09-13 06:21:51.000000000

Patch Set 6:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/3467/

-------------------------------------
author: Erick Ross
date: 2013-09-13 06:44:44.000000000

Patch Set 6: Code-Review-1

(15 comments)

There are a few things to be cleaned before this will be ready to go in.

Line:40, valgrind/org.eclipse.linuxtools.valgrind.core/src/org/eclipse/linuxtools/valgrind/core/CommandLineConstants.java -> This is new API and xxx@xxx.xxx tag.

Line:45, valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/internal/valgrind/launch/LaunchConfigurationConstants.java -> Two missing NON-NLS here.

Line:58, valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/internal/valgrind/launch/LaunchConfigurationConstants.java -> And another missing NON-NLS.

Line:74, valgrind/org.eclipse.linuxtools.valgrind.launch/schema/customMallocLibraries.exsd -> Misses since 2.2 as this is the release it will appear in.

Line:83, valgrind/org.eclipse.linuxtools.valgrind.launch/schema/customMallocLibraries.exsd -> Adding a sample usage is really convenient when one tries to implement extension point.

Line:329, valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/internal/valgrind/launch/ValgrindOptionsTab.java -> Missing NON-NLS.

Line:354, valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/internal/valgrind/launch/ValgrindOptionsTab.java -> Few missing NON-NLS here.

Line:909, valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/internal/valgrind/launch/ValgrindOptionsTab.java -> Used only in tests. It's inapropriate to expose internals of the class for the sake of testing.

Line:919, valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/internal/valgrind/launch/ValgrindOptionsTab.java -> Used only in tests. It's inapropriate to expose internals of the class for the sake of testing.

Line:923, valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/internal/valgrind/launch/ValgrindOptionsTab.java -> Not used anywhere, Please drop.

Line:927, valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/internal/valgrind/launch/ValgrindOptionsTab.java -> Used only in tests. It's inapropriate to expose internals of the class for the sake of testing.

Line:931, valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/internal/valgrind/launch/ValgrindOptionsTab.java -> Used only in tests. It's inapropriate to expose internals of the class for the sake of testing.

Line:935, valgrind/org.eclipse.linuxtools.valgrind.launch/src/org/eclipse/linuxtools/internal/valgrind/launch/ValgrindOptionsTab.java -> Not used anywhere, please drop.

Line:513, valgrind/org.eclipse.linuxtools.valgrind.memcheck.tests/src/org/eclipse/linuxtools/internal/valgrind/memcheck/tests/LaunchConfigTabTest.java -> Test methods not annotated xxx@xxx.xxx will not be run with Junit 4.x as we no longer extend TestCase.

Line:559, valgrind/org.eclipse.linuxtools.valgrind.memcheck.tests/src/org/eclipse/linuxtools/internal/valgrind/memcheck/tests/LaunchConfigTabTest.java -> Test methods not annotated xxx@xxx.xxx will not be run with Junit 4.x as we no longer extend TestCase.

-------------------------------------
author: Brenden Conley
date: 2013-09-13 06:48:53.000000000

Patch Set 6: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/3467/ : SUCCESS

-------------------------------------
author: Erick Ross
date: 2013-10-10 10:38:35.000000000

Patch Set 6:

If noone plans on finishing this one I'm going to abandon it in 2 weeks as constantly going through same reviews is just time lost.

-------------------------------------
author: Erick Ross
date: 2013-11-18 16:40:03.000000000

Abandoned

More than a month passed. Abandoning. Please submit new patch for review when ready. We have to keep the review queue sane.

-------------------------------------
