DESCRIPTION

Introduce Call Stack view and state system

Change-Id: I794b6ea9758614e7a595705d9728ca8f5a588975
Signed-off-by: Luciana Barry xxx@xxx.xxx


COMMENTS

author: Luciana Barry
date: 2013-04-29 18:42:18.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2013-04-29 19:11:14.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/2104/ 

-------------------------------------
author: Braxton Mccarthy
date: 2013-04-29 19:15:15.000000000

Patch Set 2: I would prefer that you didn't submit this

(10 inline comments)



Line:212, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/callstack/CallStackEntry.java -> here too

Line:72, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/callstack/CallStackStateProvider.java -> why not static final too?

Line:103, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/callstack/CallStackStateProvider.java -> there could be only 1 try here, with the if inside.

Line:114, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/callstack/CallStackStateProvider.java -> this could be a } else if { , would be a tad faster.

Line:119, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/callstack/CallStackStateProvider.java -> We could compare the return value here with functionExitName, as a kind of sanity check. Obviously not crash the program, but maybe logging it or something?

Line:55, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/callstack/CallStackEvent.java -> not a big deal, but you can use getClass().getSimpleName() instead of hard-coding the class's name. That way sub-classes that don't add fields can reuse it.

Line:107, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/callstack/CallStackView.java -> These names should be externalized

Line:468, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/callstack/CallStackView.java -> no!

Line:580, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/callstack/CallStackView.java -> no!

Line:982, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/callstack/CallStackView.java -> Should also be externalized

-------------------------------------
author: Brenden Conley
date: 2013-04-29 19:26:44.000000000

Patch Set 2: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/2104/ : SUCCESS

-------------------------------------
author: Braxton Mccarthy
date: 2013-04-29 19:28:09.000000000

Patch Set 2: (1 inline comment)



Line:114, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/callstack/CallStackStateProvider.java -> I'm dumb, it wouldn't be any faster. It would save one level of indentation though!

-------------------------------------
