DESCRIPTION

lttng: Support for port number in lttng control (bug 406122)

Change-Id: I38ce9ea1e84f3a57c28cb9877d2033cf42b0af57
Signed-off-by: Ricky Reeves <Meredith xxx@xxx.xxx


COMMENTS

author: Ricky Reeves
date: 2013-04-23 20:03:40.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2013-04-23 20:03:45.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/2020/ 

-------------------------------------
author: Brenden Conley
date: 2013-04-23 20:18:46.000000000

Patch Set 2: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/2020/ : SUCCESS

-------------------------------------
author: Luciana Barry
date: 2013-04-23 20:29:49.000000000

Patch Set 2: Looks good to me, approved; IP review completed



-------------------------------------
author: Braxton Mccarthy
date: 2013-04-23 21:43:28.000000000

Patch Set 2: I would prefer that you didn't submit this

(8 inline comments)



Line:2, lttng/org.eclipse.linuxtools.lttng2.ui.tests/stubs/org/eclipse/linuxtools/internal/lttng2/stubs/service/TestRemoteSystemProxy.java -> Should be "2012, 2013"

Line:2, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/NewConnectionDialog.java -> Should be "2012, 2013"

Line:151, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/NewConnectionDialog.java -> unneeded comment, see https://git.eclipse.org/r/#/c/12141/

Line:180, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/NewConnectionDialog.java -> unneeded comment, see https://git.eclipse.org/r/#/c/12141/

Line:2, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/remote/RemoteSystemProxy.java -> I think what Patrick meant was "2012, 2013"

Line:145, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/remote/RemoteSystemProxy.java -> Those comments aren't needed, see the commit message in https://git.eclipse.org/r/#/c/12141/

Line:2, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/handlers/NewConnectionHandler.java -> Should be "2012, 2013"

Line:2, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/INewConnectionDialog.java -> Should be "2012, 2013"

-------------------------------------
author: Braxton Mccarthy
date: 2013-04-23 21:44:26.000000000

Patch Set 2: Do not submit

Sorry for saying "-2", but a -1 doesn't show over a +2 ;)

-------------------------------------
author: Ricky Reeves
date: 2013-04-24 11:48:58.000000000

Patch Set 2: (8 inline comments)

Thanks for the comments. Sloppy by me about the copyright year. Not usually like me :-(

New patch to come ...

Line:2, lttng/org.eclipse.linuxtools.lttng2.ui.tests/stubs/org/eclipse/linuxtools/internal/lttng2/stubs/service/TestRemoteSystemProxy.java -> Done

Line:2, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/NewConnectionDialog.java -> Done

Line:151, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/NewConnectionDialog.java -> Done

Line:180, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/NewConnectionDialog.java -> Done

Line:2, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/remote/RemoteSystemProxy.java -> Done

Line:145, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/remote/RemoteSystemProxy.java -> Done

Line:2, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/handlers/NewConnectionHandler.java -> Done

Line:2, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/dialogs/INewConnectionDialog.java -> Done

-------------------------------------
