DESCRIPTION

Add hover help and documentation for probe variables

Change-Id: I9b690be8560c20eff7e1f18f7c0e6ced4f8ab2ab


COMMENTS

author: Brenden Conley
date: 2013-04-11 19:42:26.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/1941/ 

-------------------------------------
author: Brenden Conley
date: 2013-04-11 19:57:19.000000000

Patch Set 1: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/1941/ : SUCCESS

-------------------------------------
author: Octavio Lucero
date: 2013-04-12 18:49:10.000000000

Patch Set 1: (1 inline comment)

Change looks good to me. Just noticed a small issue described in the inline comment.

Line:175, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/editors/stp/STPCompletionProcessor.java -> Documentation for the first auto-completion list item does not appear.  This does not happen hovering over a probe variable, in that case documentation is properly displayed. 

I think the problem is in this line; variableName only includes the string to be inserted into the document, which might just be part of a probe variable name. Maybe prefix + variableName should be passed here instead?

-------------------------------------
author: Octavio Lucero
date: 2013-04-12 20:35:15.000000000

Patch Set 1: (1 inline comment)



Line:175, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/editors/stp/STPCompletionProcessor.java -> I tried this and it fixed the problem, but have not tested the solution thoroughly.

-------------------------------------
author: Kamila Nguyen
date: 2013-04-12 20:37:05.000000000

Patch Set 1: (1 inline comment)



Line:175, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/editors/stp/STPCompletionProcessor.java -> Of course!.. good catch!

-------------------------------------
