DESCRIPTION

[Tmf][Ctf] Add descriptive fail to import messages.

This patch proposes a way of showing more error details.
The ctf modifications use reflexion since the parser and lexer are
auto-generated. Now with number format exceptions for ints

Change-Id: I74cbbd4aaff29f458786ffc96e88b5416b49beed
Signed-off-by: Ivy Mitchell xxx@xxx.xxx

COMMENTS

author: Ivy Mitchell
date: 2013-04-18 17:41:23.000000000

Uploaded patch set 6.

-------------------------------------
author: Brenden Conley
date: 2013-04-18 17:41:28.000000000

Patch Set 6:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/1989/ 

-------------------------------------
author: Brenden Conley
date: 2013-04-18 17:58:19.000000000

Patch Set 6: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/1989/ : SUCCESS

-------------------------------------
author: Luciana Barry
date: 2013-04-19 14:45:09.000000000

Patch Set 6: (9 inline comments)

General comment: sometimes (usually?) we suppress javadoc warnings in Messages.java files so we don't have to document every string

Line:501, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/parsers/custom/CustomXmlTrace.java -> PLUGIN_ID

Line:35, lttng/org.eclipse.linuxtools.gdbtrace.core/src/org/eclipse/linuxtools/internal/gdbtrace/core/Activator.java -> should be .gdbtrace.core

Line:381, lttng/org.eclipse.linuxtools.tmf.core.tests/stubs/org/eclipse/linuxtools/tmf/tests/stubs/trace/TmfTraceStub.java -> shouldn't this be $NON-NLS-1$?

Line:134, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/project/handlers/SelectTraceTypeHandler.java -> please check comments from patch set 5 on this file

Line:92, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFReaderException.java -> Parameter type could be MismatchedTokenException directly?

Line:116, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFReaderException.java -> the... ?

Line:122, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFReaderException.java -> fp :(

Line:14, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/ctfadaptor/Messages.java -> This string no longer used

Line:399, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/parsers/custom/CustomTxtTrace.java -> PLUGIN_ID

-------------------------------------
author: Gerrit Code Review
date: 2013-04-22 22:06:42.000000000

Your change could not be merged due to a path conflict.

Please merge (or rebase) the change locally and upload the resolution for review.

-------------------------------------
