DESCRIPTION

tmf: Add a state system explorer view

This view displays raw state system information, synchronized with
the currently selected timestamp. This is amazingly useful for
debugging, but could also be useful for end-users trying to get
more low-level information.

For this reason, it's shipped with the runtime plugin, but not
present in the default perspective.

Based on initial implementation by Ayanna Reed.

Change-Id: I2dc6b798862039b1c5c18ec5418d7f5913e27dcc
Signed-off-by: Braxton Mccarthy xxx@xxx.xxx


COMMENTS

author: Braxton Mccarthy
date: 2013-04-10 22:32:50.000000000

Uploaded patch set 4.

-------------------------------------
author: Brenden Conley
date: 2013-04-10 23:28:14.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/1927/ 

-------------------------------------
author: Brenden Conley
date: 2013-04-10 23:43:10.000000000

Patch Set 4: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/1927/ : SUCCESS

-------------------------------------
author: Ricky Reeves
date: 2013-04-15 13:37:10.000000000

Patch Set 4: I would prefer that you didn't submit this

(5 inline comments)

minor comments

Line:220, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/statesystem/TmfStateSystemExplorer.java -> Don't use e.printStackTrace();

Line:276, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/statesystem/TmfStateSystemExplorer.java -> Don't use e.printStackTrace();

Line:337, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/statesystem/TmfStateSystemExplorer.java -> Don't use e.printStackTrace();

Line:364, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/statesystem/TmfStateSystemExplorer.java -> remove FIXME. Fix it accordingly (if needed)

Line:410, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/statesystem/TmfStateSystemExplorer.java -> in traceSelected() you are using trace.equals() instead of ==.

-------------------------------------
author: Braxton Mccarthy
date: 2013-04-15 20:26:56.000000000

Patch Set 4: (2 inline comments)

Comments on PS4

-------------------------------------
author: Braxton Mccarthy
date: 2013-04-15 20:26:55.000000000

MISMATCHED INLINE COMMENT
Line:364, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/statesystem/TmfStateSystemExplorer.java -> Fixing this will be much easier once/if we move to a TreeViewer (using a LabelProvider). For now I could remove the FIXME, but I'd rather leave it so we don't forget. Thoughts?

-------------------------------------
author: Braxton Mccarthy
date: 2013-04-15 20:26:55.000000000

MISMATCHED INLINE COMMENT
Line:410, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/statesystem/TmfStateSystemExplorer.java -> The trace objects are supposed to be unique. I'll use == in both cases. (that's what is normally used in those signal handlers iirc).

-------------------------------------
