DESCRIPTION

profiling/o.e.l.dataviewers.charts: code review:
- cleanup NLS and NON-NLS Strings
- cleanup of Exception handling
- remove a bit of unused code
- better management of Colors


COMMENTS

author: Brenden Conley
date: 2013-03-19 16:16:59.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/1722/ 

-------------------------------------
author: Erick Ross
date: 2013-03-19 16:21:14.000000000

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)



Line:25, profiling/org.eclipse.linuxtools.dataviewers.charts/src/org/eclipse/linuxtools/internal/dataviewers/charts/Messages.java -> NLS classes are not supposed to contain constants but only translateable strings. Please extract the constants in another unit.

-------------------------------------
author: Brenden Conley
date: 2013-03-19 16:37:41.000000000

Patch Set 1: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/1722/ : SUCCESS

-------------------------------------
