DESCRIPTION

Valgrind: Adding mouse-hover tooltip in cachegrind view to alert users
that ??? means cachegrind could not retrieve names from debug info

Change-Id: I6216c2e150cbff37d3d0f7fb7a70fe5af6acbe12


COMMENTS

author: Brenden Conley
date: 2013-03-15 14:49:43.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/1694/ 

-------------------------------------
author: Brenden Conley
date: 2013-03-15 15:03:43.000000000

Patch Set 1: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/1694/ : SUCCESS

-------------------------------------
author: Octavio Lucero
date: 2013-03-15 15:22:05.000000000

Patch Set 1: I would prefer that you didn't submit this

(3 inline comments)

Change looks good to me, just a couple of missing NON-NLS.

Line:35, valgrind/org.eclipse.linuxtools.valgrind.cachegrind/src/org/eclipse/linuxtools/internal/valgrind/cachegrind/CachegrindLabelProvider.java -> Add missing //$NON-NLS-1$

Line:110, valgrind/org.eclipse.linuxtools.valgrind.cachegrind/src/org/eclipse/linuxtools/internal/valgrind/cachegrind/CachegrindLabelProvider.java -> Add missing //$NON-NLS-1$

Line:116, valgrind/org.eclipse.linuxtools.valgrind.cachegrind/src/org/eclipse/linuxtools/internal/valgrind/cachegrind/CachegrindLabelProvider.java -> Add missing //$NON-NLS-1$

-------------------------------------
