DESCRIPTION

lttng: add command execution timeout preference

Change-Id: Ia3b09ad1260517ead01c53dd21cfa97a0484ad03
Signed-off-by: Ricky Reeves xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2013-03-12 17:24:32.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/1641/ 

-------------------------------------
author: Brenden Conley
date: 2013-03-12 17:38:30.000000000

Patch Set 1: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/1641/ : SUCCESS

-------------------------------------
author: Luciana Barry
date: 2013-03-12 17:41:47.000000000

Patch Set 1: (2 inline comments)



Line:60, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/preferences/ControlPreferences.java -> timout > timeout

Line:92, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/preferences/ControlPreferences.java -> Seems long for a minimum timeout (since it's configurable). What is the normal successful time?

-------------------------------------
author: Ricky Reeves
date: 2013-03-12 17:57:01.000000000

Patch Set 1: (2 inline comments)



Line:60, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/preferences/ControlPreferences.java -> Done

Line:92, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/preferences/ControlPreferences.java -> It's hard to say. When executing a (long) command (e.g. lttng list <session>), there could be a lot of String lines to be read. Depending on the network latency it could take some time. However, I can but it 5 seconds.

-------------------------------------
