DESCRIPTION

Add support for saving perf stat sessions.

Created abstract class that can be used for implementing later save
session command handlers (i.e. disassembly session). Refactored
PerfSaveSessionHandler to use this abstract class.

Change-Id: I4da01e98f83232841d2d1b1b1ada639544ecfd2f


COMMENTS

author: Brenden Conley
date: 2013-03-05 17:17:30.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/1577/ 

-------------------------------------
author: Octavio Lucero
date: 2013-03-05 17:17:30.000000000

Patch Set 1:

I will add tests to avoid coverage drop.

-------------------------------------
author: Brenden Conley
date: 2013-03-05 17:30:14.000000000

Patch Set 1: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/1577/ : SUCCESS

-------------------------------------
author: Nathanael Holden
date: 2013-03-05 19:32:50.000000000

Patch Set 1: I would prefer that you didn't submit this

(5 inline comments)

I've tested the change and it seems to work. Just a few things to fix. Also, would it be possible to provide some unit tests for the handlers. ie. no need to call them with swtbot from the ui, but just test that the actions work as expected.

Line:1, perf/org.eclipse.linuxtools.perf/src/org/eclipse/linuxtools/internal/perf/ui/AbstractSaveDataHandler.java -> Please add missing license header.

Line:64, perf/org.eclipse.linuxtools.perf/src/org/eclipse/linuxtools/internal/perf/ui/AbstractSaveDataHandler.java -> for ease of understanding, maybe this should be called canSave

Line:1, perf/org.eclipse.linuxtools.perf/src/org/eclipse/linuxtools/internal/perf/ui/PerfSaveStatsHandler.java -> Please add missing license file.

Line:36, perf/org.eclipse.linuxtools.perf/src/org/eclipse/linuxtools/internal/perf/ui/PerfSaveStatsHandler.java -> I think a try-catch-finally should be used, with the buffer being closed in the finally block.

Line:8, perf/org.eclipse.linuxtools.perf/src/org/eclipse/linuxtools/internal/perf/ui/messages.properties -> There should be a space between '{0}' and '?' .

-------------------------------------
author: Octavio Lucero
date: 2013-03-05 19:34:41.000000000

Patch Set 1:

Thanks for the comments, I'm currently implementing the tests.

-------------------------------------
author: Nathanael Holden
date: 2013-03-05 19:35:36.000000000

Patch Set 1: (3 inline comments)



Line:19, perf/org.eclipse.linuxtools.perf/src/org/eclipse/linuxtools/internal/perf/ui/PerfSaveSessionHandler.java -> Short class description

Line:17, perf/org.eclipse.linuxtools.perf/src/org/eclipse/linuxtools/internal/perf/ui/AbstractSaveDataHandler.java -> Short class description

Line:15, perf/org.eclipse.linuxtools.perf/src/org/eclipse/linuxtools/internal/perf/ui/PerfSaveStatsHandler.java -> Short class description.

-------------------------------------
