DESCRIPTION

Update to session creation procedure

- Remove --no-consumer and --disable-consumer option because these
options will be obsolete in LTTng Tools 2.2
- Update commands and dialog boxes for this change
- Clean-ups

Change-Id: Ic89c7af3df98c25ff777eebbe1a7e15785ec91ae
Signed-off-by: Ricky Reeves xxx@xxx.xxx


COMMENTS

author: Ricky Reeves
date: 2013-02-22 14:57:20.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2013-02-22 14:57:39.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/1454/ 

-------------------------------------
author: Brenden Conley
date: 2013-02-22 15:10:35.000000000

Patch Set 2: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/1454/ : SUCCESS

-------------------------------------
author: Ivy Mitchell
date: 2013-02-22 19:58:22.000000000

Patch Set 2: Verified; I would prefer that you didn't submit this; IP review completed

(5 inline comments)

This is a good patch, but IMO it should be split into two. 

patchset1: update headers for previous work. 

patchset2 Update to session creation procedure.

Line:11, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/handlers/EnableEventOnDomainHandler.java -> I don't think we need this

Line:11, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/handlers/EnableEventOnSessionHandler.java -> I don't see why this is not not necessary. It is the only change, so nothing was updated

Line:11, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/handlers/AssignEventHandler.java -> or not

Line:11, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/handlers/BaseEnableEventHandler.java -> nope

Line:11, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/handlers/EnableEventOnChannelHandler.java -> Nuh-uh

-------------------------------------
author: Ricky Reeves
date: 2013-02-25 13:58:10.000000000

Patch Set 2: (5 inline comments)



Line:11, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/handlers/EnableEventOnDomainHandler.java -> Was updated for filter feature which is part of LTTng Tools 2.1

Line:11, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/handlers/EnableEventOnSessionHandler.java -> Was updated for filter feature which is part of LTTng Tools 2.1

Line:11, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/handlers/AssignEventHandler.java -> Was updated for filter feature which is part of LTTng Tools 2.1

Line:11, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/handlers/BaseEnableEventHandler.java -> Was updated for filter feature which is part of LTTng Tools 2.1

Line:11, lttng/org.eclipse.linuxtools.lttng2.ui/src/org/eclipse/linuxtools/internal/lttng2/ui/views/control/handlers/EnableEventOnChannelHandler.java -> Was updated for filter feature which is part of LTTng Tools 2.1

-------------------------------------
