DESCRIPTION

Add ICommitMessageProvider2 for caret positioning in commit messages

The caret in the CommitMessageComponent is placed according to the
value of getDesiredCaretPosition() of the first implementation of
ICommitMessageProvider2 that provides caret position. In case there
are multiple implementations available that provide a defined caret
position the second and subsequent positions are ignored.

Commit messages are not trimmed anymore to ensure consistency between
a provided message and the provided caret position.

Includes unit and UI tests.

Bug: 516867
Change-Id: I1b0ffd33ef37196d53077d09774672c2b033835f
Signed-off-by: James Mcgee xxx@xxx.xxx
Signed-off-by: Alayna Houston xxx@xxx.xxx

COMMENTS

author: James Mcgee
date: 2017-06-23 08:36:42.000000000

Uploaded patch set 26.

-------------------------------------
author: Brenden Conley
date: 2017-06-23 08:36:48.000000000

Patch Set 26:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/9972/

-------------------------------------
author: Brenden Conley
date: 2017-06-23 09:01:57.000000000

Patch Set 26: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/9972/ : SUCCESS

-------------------------------------
author: Alayna Houston
date: 2017-06-23 09:08:49.000000000

Patch Set 26: Code-Review-1

(2 comments)

Line:71, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageComponentStateManager.java -> These two lines should come before the if. (Remove in the other branch.)

Line:75, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageComponentStateManager.java -> And this will prevent future additions since this version will not be able to read them. Keep the < logic from the base version (" < MEMBER_COUNT_WITHOUT_CARET_POSITION ") in line 57 and just ignore any extra items in the array instead of returning null.

-------------------------------------
author: James Mcgee
date: 2017-06-23 09:26:43.000000000

Patch Set 26:

(3 comments)

Line:71, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageComponentStateManager.java -> Done.

Line:75, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageComponentStateManager.java -> Done

-------------------------------------
