DESCRIPTION

Add ICommitMessageProvider2 for caret positioning in commit messages

The caret in the CommitMessageComponent is placed according to the
value of getDesiredCaretPosition() of the first implementation of
ICommitMessageProvider2 that provides caret position. In case there
are multiple implementations available that provide a defined caret
position the second and subsequent positions are ignored.

Commit messages are not trimmed anymore to ensure consistency between
a provided message and the provided caret position.

Includes unit and UI tests.

Bug: 516867
Change-Id: I1b0ffd33ef37196d53077d09774672c2b033835f
Signed-off-by: James Mcgee xxx@xxx.xxx
Signed-off-by: Alayna Houston xxx@xxx.xxx

COMMENTS

author: James Mcgee
date: 2017-06-14 07:29:55.000000000

Uploaded patch set 18: Patch Set 17 was rebased.

-------------------------------------
author: Brenden Conley
date: 2017-06-14 07:30:01.000000000

Patch Set 18:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/9931/

-------------------------------------
author: Brenden Conley
date: 2017-06-14 07:54:14.000000000

Patch Set 18: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/9931/ : SUCCESS

-------------------------------------
author: Douglas Trujillo
date: 2017-06-14 11:26:05.000000000

Patch Set 18:

(17 comments)

Line:54, org.eclipse.egit.ui/src/org/eclipse/egit/ui/ICommitMessageProvider2.java -> maybe shorter just caretPosition ?

Line:58, org.eclipse.egit.ui/src/org/eclipse/egit/ui/ICommitMessageProvider2.java -> and

Line:701, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageComponent.java -> and cherry-pick ?

Line:78, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> I'd name this just message

Line:79, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> there are a lot of blank lines in this class

Line:88, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> unnecessary comment

Line:123, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> inline

Line:151, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> isn't that obvious looking at the code ?

Line:159, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> unnecessary comment

Line:181, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> formatting of this statement looks odd

Line:184, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> can we find a shorter name ?

Line:193, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> providers

Line:195, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> this can be inlined as the registry is used only once

Line:217, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> odd formatting

Line:228, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> toResourceArray, missing blank at the end

Line:229, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> paths ?

Line:235, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> missing braces

-------------------------------------
author: James Mcgee
date: 2017-06-15 08:23:57.000000000

MISMATCHED INLINE COMMENT
Line:54, org.eclipse.egit.ui/src/org/eclipse/egit/ui/ICommitMessageProvider2.java -> Done

-------------------------------------
author: James Mcgee
date: 2017-06-15 08:23:57.000000000

MISMATCHED INLINE COMMENT
Line:58, org.eclipse.egit.ui/src/org/eclipse/egit/ui/ICommitMessageProvider2.java -> Done

-------------------------------------
author: James Mcgee
date: 2017-06-15 08:23:57.000000000

MISMATCHED INLINE COMMENT
Line:701, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageComponent.java -> Right, cherry-pick, too.
Done.

-------------------------------------
author: James Mcgee
date: 2017-06-15 08:23:57.000000000

MISMATCHED INLINE COMMENT
Line:78, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> Done

-------------------------------------
author: James Mcgee
date: 2017-06-15 08:23:57.000000000

MISMATCHED INLINE COMMENT
Line:79, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> Done

-------------------------------------
author: James Mcgee
date: 2017-06-15 08:23:57.000000000

MISMATCHED INLINE COMMENT
Line:88, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> Done

-------------------------------------
author: James Mcgee
date: 2017-06-15 08:23:57.000000000

MISMATCHED INLINE COMMENT
Line:123, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> Done

-------------------------------------
author: James Mcgee
date: 2017-06-15 08:23:57.000000000

MISMATCHED INLINE COMMENT
Line:151, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> Done

-------------------------------------
author: James Mcgee
date: 2017-06-15 08:23:57.000000000

MISMATCHED INLINE COMMENT
Line:159, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> Done

-------------------------------------
author: James Mcgee
date: 2017-06-15 08:23:57.000000000

MISMATCHED INLINE COMMENT
Line:181, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> That's, how the save action formats the code.
Formatter: "Unmanaged profile 'JGit Format'".

-------------------------------------
author: James Mcgee
date: 2017-06-15 08:23:57.000000000

MISMATCHED INLINE COMMENT
Line:184, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> How about "CommitDialog_IgnoreCaretPosition"?

-------------------------------------
author: James Mcgee
date: 2017-06-15 08:23:57.000000000

MISMATCHED INLINE COMMENT
Line:193, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> Done

-------------------------------------
author: James Mcgee
date: 2017-06-15 08:23:57.000000000

MISMATCHED INLINE COMMENT
Line:195, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> Done

-------------------------------------
author: James Mcgee
date: 2017-06-15 08:23:57.000000000

MISMATCHED INLINE COMMENT
Line:217, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> see above

-------------------------------------
author: James Mcgee
date: 2017-06-15 08:23:57.000000000

MISMATCHED INLINE COMMENT
Line:228, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> Renaming done.
What do you mean by "missing blank at the end"?

-------------------------------------
author: James Mcgee
date: 2017-06-15 08:23:57.000000000

MISMATCHED INLINE COMMENT
Line:229, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> Done

-------------------------------------
author: James Mcgee
date: 2017-06-15 08:23:57.000000000

MISMATCHED INLINE COMMENT
Line:235, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageCalculator.java -> Done

-------------------------------------
