DESCRIPTION

bug 515088 - [staging view] double click on node should expand

Change-Id: Ie7e79709834bbe169b07bcddfb412cfed82d420a
Signed-off-by: Regan Klein xxx@xxx.xxx

COMMENTS

author: Regan Klein
date: 2017-05-09 15:49:01.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2017-05-09 15:49:07.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/9811/

-------------------------------------
author: Brenden Conley
date: 2017-05-09 16:11:12.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/9811/ : SUCCESS

-------------------------------------
author: Alayna Houston
date: 2017-05-10 09:23:56.000000000

Patch Set 1:

(1 comment)

Line:2007, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingView.java -> While I don't notice any detrimental effects, this also does something for leaves, which fires off quite some machinery in TreeViewer that ultimately does nothing. Also, selection.getFirstElement() may in theory return null (though that should never happen -- we should never get a double click event with an empty selection).

But how about guarding the setExpandedState() call with

  if (selectedNode instanceof StagingFolderEntry) {
    ...
  }

?

-------------------------------------
author: Alayna Houston
date: 2017-05-10 09:25:07.000000000

Patch Set 1:

(1 comment)

Line:7, /COMMIT_MSG -> Please follow the EGit guidelines on commit messages: https://wiki.eclipse.org/EGit/Contributor_Guide#Commit_message_guidelines

-------------------------------------
author: Regan Klein
date: 2017-05-10 19:34:38.000000000

Patch Set 1:

> (1 comment)

Done, thank you for your feedback.

-------------------------------------
author: Regan Klein
date: 2017-05-10 19:34:49.000000000

Patch Set 1:

> (1 comment)

Done.

-------------------------------------
