DESCRIPTION

Look for a ChangeId in the footer, not in the body

Use the new util method from ChangeIdUtil to find the correct index of
the ChangeId entry in the commit message footer. 

Depends on jgit's change I87ecca009ca3bff1ca0de3c436ebd95736bf5a10.

Change-Id: I4b35236f6602ee5ef8a3fbc6c7f4ce56d1285a8a
Signed-off-by: Carlie Harper xxx@xxx.xxx

COMMENTS

author: Carlie Harper
date: 2013-01-28 09:44:06.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2013-01-28 09:44:12.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/4097/ 

-------------------------------------
author: Brenden Conley
date: 2013-01-28 09:56:47.000000000

Patch Set 2: I would prefer that you didn't submit this

Build Unstable 

https://hudson.eclipse.org/sandbox/job/egit.gerrit/4097/ : UNSTABLE

-------------------------------------
author: Brenden Conley
date: 2013-01-28 10:15:48.000000000

Patch Set 2: No score

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/4098/ 

-------------------------------------
author: Brenden Conley
date: 2013-01-28 10:28:16.000000000

Patch Set 2: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/egit.gerrit/4098/ : SUCCESS

-------------------------------------
author: Danika Greer
date: 2013-02-01 20:18:36.000000000

Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)



Line:677, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageComponent.java -> The other caller also needs to be adjusted for the newline difference (refreshChangeIdText). You can reproduce the problem with this message when repeatedly pressing the change-ID button:

    Test

    Bug: 398461
    Change-Id: I68405ae952b1fd9e6f73a94711ce9363f1159735
    Signed-off-by: Douglas Trujillo xxx@xxx.xxx

-------------------------------------
author: Douglas Trujillo
date: 2013-02-03 00:11:55.000000000

Patch Set 2: (1 inline comment)



Line:677, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitMessageComponent.java -> refreshChangeIdText didn't remove the newline after the changeId when removing the changeId, fixed that

-------------------------------------
author: Gerrit Johnathan Pham
date: 2013-02-06 00:37:12.000000000

Your change could not be merged due to a path conflict.

Please merge (or rebase) the change locally and upload the resolution for review.

-------------------------------------
author: Gerrit Johnathan Pham
date: 2013-02-06 00:37:19.000000000

Your change could not be merged due to a path conflict.

Please merge (or rebase) the change locally and upload the resolution for review.

-------------------------------------
