DESCRIPTION

Make all methods and states of RepositoryState testable properties

E.g. if the current repository state is SAFE, then the isSafe
property of GitResource and GitRepository will be true. The methods,
like canResetHead is also testable. This applies both for
RepositoriesViewProprtyTester (applicable in the Git Repositories View),
as well as for ResourcePropertiesTester (applicable for resources).

For now, we only declare the properties that we actually use in the
properties testers section in plugin.xml.

Change-Id: I5c72f66ceac7678a03c85794251304a3db82d196


COMMENTS

author: Brenden Conley
date: 2013-01-15 12:58:15.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/4001/ 

-------------------------------------
author: Brenden Conley
date: 2013-01-15 13:10:32.000000000

Patch Set 4: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/egit.gerrit/4001/ : SUCCESS

-------------------------------------
author: Douglas Trujillo
date: 2013-01-16 21:41:46.000000000

Patch Set 4: I would prefer that you didn't submit this

(3 inline comments)



Line:93, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/ResourcePropertyTester.java -> s/of/if/

Line:110, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/ResourcePropertyTester.java -> why don't you simply leave out the varargs arguments instead of casting null ?

 class.getMethod(property)

Line:112, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/ResourcePropertyTester.java -> why don't you simply leave out the varargs arguments instead of casting null ?

 method.invoke(state)

-------------------------------------
author: Juliet Cantu
date: 2013-01-23 17:10:20.000000000

Patch Set 4: (3 inline comments)



Line:93, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/ResourcePropertyTester.java -> Done

Line:110, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/ResourcePropertyTester.java -> I can do that?!
Done

Line:112, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/ResourcePropertyTester.java -> Done

-------------------------------------
