DESCRIPTION

bug 515040 - No mnemonics for "Commit and Push" and "Commit" buttons in
Git Staging view

Change-Id: I2782b993f9eb431f94bc5da77684bf7c7dbc6750
Signed-off-by: Regan Klein xxx@xxx.xxx

COMMENTS

author: Regan Klein
date: 2017-04-11 00:08:55.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2017-04-11 00:09:01.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/9722/

-------------------------------------
author: Brenden Conley
date: 2017-04-11 00:32:04.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/9722/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2017-04-11 06:42:11.000000000

Patch Set 1: Code-Review+1

Andrey or Thomas, can you review this one?

-------------------------------------
author: Jack Yu
date: 2017-04-18 09:27:10.000000000

Patch Set 1: Code-Review+1

-------------------------------------
author: Alayna Houston
date: 2017-04-20 08:04:22.000000000

Patch Set 1:

(2 comments)

Line:1806, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/uitext.properties -> I'm on a Mac, where there are no mnemonics. Did you double-check that &C and &P don't conflict with anything else (like "Copy" and "Paste" in the context menu of the
commit message)?

Line:11, /COMMIT_MSG -> Please follow the EGit guidelines for commit messages:

http://wiki.eclipse.org/EGit/Contributor_Guide#Commit_message_guidelines

Something like:

  Add mnemonics to buttons in staging view

  Give the "Commit and Push" and the "Commit" buttons
  mnemonics &P and &C, respectively.

  Bug: 515040
  Change-Id: ...
  Signed-off-by: ...

-------------------------------------
author: Regan Klein
date: 2017-04-20 08:49:00.000000000

Patch Set 1:

(1 comment)

Line:1806, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/uitext.properties -> Since you have to press ALT+Mnemonic key this shouldn't be an issue.

-------------------------------------
author: Gerrit Johnathan Pham
date: 2017-04-20 10:18:21.000000000

Change has been successfully merged into the git repository by Alayna Houston

-------------------------------------
