DESCRIPTION

Bug 514320 - Use verbs in PullResultDialog instead of OK

Change-Id: I5b01b2b442922fee53b48e550846c66996ae8dfe
Signed-off-by: Simon Ellison xxx@xxx.xxx

COMMENTS

author: Simon Ellison
date: 2017-04-03 18:54:23.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2017-04-03 18:54:29.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/9716/

-------------------------------------
author: Zaid Mosley
date: 2017-04-03 18:55:55.000000000

Patch Set 1: Code-Review-1

(1 comment)

Line:733, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/uitext.properties -> Mnemonic missing.

-------------------------------------
author: Zaid Mosley
date: 2017-04-03 19:07:52.000000000

Patch Set 1: Code-Review+1

David pointed me to the user guideline wiki, which say, mnemonics should be avoided for Close. https://wiki.eclipse.org/User_Interface_Guidelines#Mnemonics

Thanks David, looks good to me in this case.

-------------------------------------
author: Brenden Conley
date: 2017-04-03 19:17:35.000000000

Patch Set 1: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit.gerrit/9716/ : UNSTABLE

-------------------------------------
author: Zaid Mosley
date: 2017-04-04 15:38:08.000000000

Patch Set 1: Code-Review-1

(1 comment)

Line:150, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/pull/PullResultDialog.java -> I recommend to use IDialogConstants.CLOSE_LABEL. It does define a mnemonic but I think that is better compare to defining a new string constants (also I find it a bit silly that close should have no mnemonic).

-------------------------------------
author: Alayna Houston
date: 2017-04-20 08:19:41.000000000

Patch Set 1:

(1 comment)

Line:150, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/pull/PullResultDialog.java -> I agree.

-------------------------------------
author: Gerrit Johnathan Pham
date: 2017-05-05 09:43:54.000000000

Change has been successfully merged into the git repository by Alayna Houston

-------------------------------------
