DESCRIPTION

Prevent IO_FAILURE by checking for conflicts in ref name validation

E.g. "a/1" is a conflict if "a" already exists, "b" is a conflict if
"b/1" already exists.

Bug: 393914
Change-Id: Ibea9984121ae88c488858b8a8e73b593195b15e0


COMMENTS

author: Brenden Conley
date: 2012-12-22 14:37:49.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/3882/ 

-------------------------------------
author: Brenden Conley
date: 2012-12-22 14:51:27.000000000

Patch Set 1: I would prefer that you didn't submit this

Build Unstable 

https://hudson.eclipse.org/sandbox/job/egit.gerrit/3882/ : UNSTABLE

-------------------------------------
author: Douglas Trujillo
date: 2012-12-24 00:06:07.000000000

Patch Set 1: (1 inline comment)



Line:57, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/ValidationUtils.java -> could we also show the conflicting ref ?

-------------------------------------
author: Danika Greer
date: 2012-12-24 15:59:15.000000000

Patch Set 1: (1 inline comment)



Line:57, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/ValidationUtils.java -> Not with the current JGit API, see RefDatabase#isNameConflicting and subclasses. Adding a new abstract method like getConflictingName would break subclasses, unless we add a default implementation.

-------------------------------------
author: Juliet Cantu
date: 2013-01-11 20:56:36.000000000

Patch Set 1: (1 inline comment)



Line:57, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/ValidationUtils.java -> Default implementation is the way to go.

-------------------------------------
author: Danika Greer
date: 2013-01-12 14:29:54.000000000

Patch Set 1: (1 inline comment)



Line:57, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/ValidationUtils.java -> Done, see JGit-Dependency.

-------------------------------------
