DESCRIPTION

Add interface for providing users

Change-Id: I8517eebaa6e7d3dca83d81932d440a2a39ea6328


COMMENTS

author: Henry Curry
date: 2012-12-10 19:16:02.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2012-12-10 19:16:10.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/3826/ 

-------------------------------------
author: Henry Curry
date: 2012-12-10 19:17:59.000000000

Patch Set 2: Looks good to me, but someone else must approve

1. I have authored 100% of the content I'm contributing
2. I have the rights to donate the content to Eclipse
3. I contribute the content under the EPL

-------------------------------------
author: Brenden Conley
date: 2012-12-10 19:33:29.000000000

Patch Set 2: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/egit.gerrit/3826/ : SUCCESS

-------------------------------------
author: Clay Cameron
date: 2012-12-11 22:31:07.000000000

Patch Set 2: I would prefer that you didn't submit this

(6 inline comments)



Line:19, org.eclipse.egit.ui/src/org/eclipse/egit/ui/IPersonProvider.java -> 2.2 is already rolling out.

Line:27, org.eclipse.egit.ui/src/org/eclipse/egit/ui/IPersonProvider.java -> No need to doc a private field.

Line:34, org.eclipse.egit.ui/src/org/eclipse/egit/ui/IPersonProvider.java -> Nondescriptive.

Line:43, org.eclipse.egit.ui/src/org/eclipse/egit/ui/IPersonProvider.java -> Externalize.

Line:77, org.eclipse.egit.ui/src/org/eclipse/egit/ui/IPersonProvider.java -> Should that be public?

Line:7, /COMMIT_MSG -> Some background for this change would be helpful.

-------------------------------------
author: Henry Curry
date: 2012-12-11 22:36:12.000000000

Patch Set 2: (5 inline comments)



Line:19, org.eclipse.egit.ui/src/org/eclipse/egit/ui/IPersonProvider.java -> It is fixed in my local repository.
I haven't pushed changes because I'm wainting for some reviews :)
I don't want to create a lot of patch sets.

Line:27, org.eclipse.egit.ui/src/org/eclipse/egit/ui/IPersonProvider.java -> Is it unnecessary or forbidden ?

Line:34, org.eclipse.egit.ui/src/org/eclipse/egit/ui/IPersonProvider.java -> Is the "The default constructor" more descriptive ?

Line:43, org.eclipse.egit.ui/src/org/eclipse/egit/ui/IPersonProvider.java -> Really ? Error's message that should be logged somehow (not visible to the user).

Line:77, org.eclipse.egit.ui/src/org/eclipse/egit/ui/IPersonProvider.java -> It should ;) How could I missed that ?

-------------------------------------
author: Clay Cameron
date: 2012-12-12 09:14:09.000000000

Patch Set 2: (2 inline comments)



Line:19, org.eclipse.egit.ui/src/org/eclipse/egit/ui/IPersonProvider.java -> In that case you should -1 the change.

Line:77, org.eclipse.egit.ui/src/org/eclipse/egit/ui/IPersonProvider.java -> If you provided a client for the interface that would not happen. Is there a place in EGit that can benefit from it?

-------------------------------------
author: Henry Curry
date: 2012-12-12 09:19:26.000000000

Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)



Line:77, org.eclipse.egit.ui/src/org/eclipse/egit/ui/IPersonProvider.java -> I don't understand :)
Could (re)write it differently.

Sorry, English is not my mother tongue :)

-------------------------------------
author: Clay Cameron
date: 2012-12-12 10:13:28.000000000

Patch Set 2: (1 inline comment)



Line:77, org.eclipse.egit.ui/src/org/eclipse/egit/ui/IPersonProvider.java -> What I meant was that implementing the interface for the purpose of an existing client would quickly show that the method is not visible. One of such clients could be the Commit dialog or the Staging view.

-------------------------------------
author: Clay Cameron
date: 2013-10-15 15:17:21.000000000

Abandoned

Kamil, feel free to restore the change if you plan working on it.

-------------------------------------
