DESCRIPTION

[DRAFT] Add "reviewers" section in push to gerrit dialog

Text area should contain (comma separated) list of reviewers. Reviewer
may be specified with its: name or e-mail or login.
Content assist provider is not part of this commit which means
that content assist is unavailable (always empty).

Tests still missing.

Change-Id: I254a7b4385172a1af791446860b43f561281431a


COMMENTS

author: Henry Curry
date: 2012-12-10 14:52:15.000000000

Uploaded patch set 6.

-------------------------------------
author: Henry Curry
date: 2012-12-10 14:56:56.000000000

Patch Set 6: I would prefer that you didn't submit this

1. I have authored 100% of the content I'm contributing 2. I have the rights to donate the content to Eclipse 3. I contribute the content under the EPL

-------------------------------------
author: Brenden Conley
date: 2012-12-10 15:26:51.000000000

Patch Set 6:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/3821/ 

-------------------------------------
author: Brenden Conley
date: 2012-12-10 15:44:07.000000000

Patch Set 6: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/egit.gerrit/3821/ : SUCCESS

-------------------------------------
author: Clay Cameron
date: 2012-12-10 16:01:20.000000000

Patch Set 6: (4 inline comments)



Line:70, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushToGerritPage.java -> Unrelated change.

Line:264, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushToGerritPage.java -> 1. Typo in variable name.
2. Is it "git receive-pack" or "git-receive-pack" as in org.eclipse.jgit.transport.RemoteConfig.DEFAULT_RECEIVE_PACK. If the latter, please use the constant.

Line:285, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushToGerritPage.java -> I guess that if there are no reviewers there is no need to set the receive-pack service.

Line:461, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushToGerritPage.java -> Unrelated change.

-------------------------------------
author: Henry Curry
date: 2012-12-10 17:23:20.000000000

Patch Set 6: (2 inline comments)



Line:264, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushToGerritPage.java -> Due to [1] It is "git receive-pack".

[1] http://gerrit.googlecode.com/svn/documentation/2.0.34/user-upload.html#push_create

Line:285, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushToGerritPage.java -> You're absolutely right. Will be fixed.

-------------------------------------
