DESCRIPTION

Provide a way to configure RepositoryChangeScanner interval

RepositoryChangeScanner was triggered every 10 seconds if the UI was
active. This is an overkill and causes unneeded CPU load by idling
Eclipse. This change increases the interval to 5 minutes, adds new
"Refresh interval" preference to the root Git preference page and
changes the job in the way that it listens to the preference change. If
the preference is set to 0, the job stops automatic repositories change
check.

Change-Id: I02751334d4cb6dea97f575d24a5fa24c6832eee4
Signed-off-by: Jayvion Booth xxx@xxx.xxx


COMMENTS

author: Jayvion Booth
date: 2017-01-15 07:37:45.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2017-01-15 07:37:51.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/9507/

-------------------------------------
author: Brenden Conley
date: 2017-01-15 08:00:48.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/9507/ : SUCCESS

-------------------------------------
author: Alayna Houston
date: 2017-01-15 15:20:33.000000000

Patch Set 2:

(9 comments)

Line:392, org.eclipse.egit.ui/src/org/eclipse/egit/ui/Activator.java -> If RepositoryChangeScanner.shouldSchedule() and RepositoryChangeScanner.shouldRun() are overridden, the if is not necessary here.

Line:598, org.eclipse.egit.ui/src/org/eclipse/egit/ui/Activator.java -> Leave private and override shouldSchedule() and shouldRun() instead. This would also simplify run() below.

Line:619, org.eclipse.egit.ui/src/org/eclipse/egit/ui/Activator.java -> Can be removed if shouldRun is overridden.

Line:622, org.eclipse.egit.ui/src/org/eclipse/egit/ui/Activator.java -> I don't think this is true. Our stop() method cancels and then joins this job.

Line:680, org.eclipse.egit.ui/src/org/eclipse/egit/ui/Activator.java -> If shouldSchedule() and shouldRun() are overridden, the if is not necessary here.

Line:693, org.eclipse.egit.ui/src/org/eclipse/egit/ui/Activator.java -> private

Line:699, org.eclipse.egit.ui/src/org/eclipse/egit/ui/Activator.java -> If shouldSchedule() and shouldRun() are overridden, the if is not necessary here.

Line:706, org.eclipse.egit.ui/src/org/eclipse/egit/ui/Activator.java -> private

Line:734, org.eclipse.egit.ui/src/org/eclipse/egit/ui/Activator.java -> For completeness, we should probably also remove it as listener:

  getPreferenceStore().removePropertyChangeListener(rcs);

-------------------------------------
author: Jayvion Booth
date: 2017-01-15 19:18:40.000000000

Patch Set 2:

(8 comments)

Line:598, org.eclipse.egit.ui/src/org/eclipse/egit/ui/Activator.java -> Done

Line:619, org.eclipse.egit.ui/src/org/eclipse/egit/ui/Activator.java -> Done

Line:622, org.eclipse.egit.ui/src/org/eclipse/egit/ui/Activator.java -> Done

Line:680, org.eclipse.egit.ui/src/org/eclipse/egit/ui/Activator.java -> Done

Line:693, org.eclipse.egit.ui/src/org/eclipse/egit/ui/Activator.java -> Done

Line:699, org.eclipse.egit.ui/src/org/eclipse/egit/ui/Activator.java -> Done

Line:706, org.eclipse.egit.ui/src/org/eclipse/egit/ui/Activator.java -> Done

Line:734, org.eclipse.egit.ui/src/org/eclipse/egit/ui/Activator.java -> Done

-------------------------------------
author: Gerrit Johnathan Pham
date: 2017-01-15 21:15:49.000000000

Change has been successfully merged into the git repository by Jayvion Booth

-------------------------------------
