DESCRIPTION

Add tests for integration with Synchronize view

Adds test cases for GitSynchInfo.getKind(),
GitResourceVariantComparator.compare() methods and SWTBot for UI
integration.

Bug: 316957
CQ: 4275
Change-Id: I169d38c33102494ac7f9dfc5e274aec1392850d9
Signed-off-by: Leslie Stephenson xxx@xxx.xxx
Signed-off-by: Douglas Trujillo xxx@xxx.xxx


COMMENTS

author: Leslie Stephenson
date: 2010-06-19 16:21:03.000000000

Uploaded patch set 7.

-------------------------------------
author: Leslie Stephenson
date: 2010-06-19 16:24:18.000000000

Patch Set 7:

Rebases on top of change I169d38c3. This change should fix SynchronizeViewTest.shouldReturnNoChanges() on Windows platform.

-------------------------------------
author: Douglas Trujillo
date: 2010-06-19 22:57:16.000000000

Patch Set 7: (6 inline comments)

- good, all tests are passing now
- some style nits and typos found
- some tests must be wrong or missing see bug 317371
- I'll try to understand the tests in detail soon

Line:64, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/EGitTestCase.java -> style nit: no braces around single line

Line:236, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/views/synchronize/SynchronizeViewTest.java -> style nit: no braces around single line

Line:34, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/GitCloneWizardTest.java -> how is this related to this change ?

Line:115, org.eclipse.egit.core.test/src/org/eclipse/egit/core/synchronize/GitResourceVariantComparatorTest.java -> this method name sounds strange, what do you mean with shouldTrueFalse ?

Line:318, org.eclipse.egit.core.test/src/org/eclipse/egit/core/synchronize/GitSyncInfoTest.java -> typo in method name : s/Deletation/Deletion/

Line:55, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/GitImportRepoWizard.java -> style nit: no braces around single line

-------------------------------------
author: Douglas Trujillo
date: 2010-06-19 22:57:33.000000000

Patch Set 7: I would prefer that you didn't submit this



-------------------------------------
author: Leslie Stephenson
date: 2010-06-19 23:33:16.000000000

Patch Set 7:

I think that in next two days I'll add tests for:
* GitResourceVariantTree
* GitSynchronizeWizard
* GitSynchronizeWizardPage

Bug 317371 needs more investigation from my side. I is possible that this is a know bug, since resource that are committed from Synchronization View doesn't immediately disappear form view. I'll investigate that and of course send a patch with fix for this issue ;)

-------------------------------------
author: Leslie Stephenson
date: 2010-06-19 23:56:18.000000000

Patch Set 7: (6 inline comments)



Line:64, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/EGitTestCase.java -> Done

Line:236, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/views/synchronize/SynchronizeViewTest.java -> Done

Line:34, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/GitCloneWizardTest.java xxx@xxx.xxx annotation were moved into EGitTestCase class. This change belongs also to this patch set.

Line:115, org.eclipse.egit.core.test/src/org/eclipse/egit/core/synchronize/GitResourceVariantComparatorTest.java -> s/TrueFalse/ReturnTrue/

Done

Line:318, org.eclipse.egit.core.test/src/org/eclipse/egit/core/synchronize/GitSyncInfoTest.java -> Done

Line:55, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/GitImportRepoWizard.java -> Done

-------------------------------------
