DESCRIPTION

Refactored UI tests

All common classes moved into org.eclipse.egit.ui.common package.
Created EGitTestCase class, a base class for EGit SWTBoot tests.

Bug: 316954
Change-Id: I4575638c11456d6621b6f9831fab60fd2efa9f71
Signed-off-by: Leslie Stephenson xxx@xxx.xxx
Signed-off-by: Douglas Trujillo xxx@xxx.xxx


COMMENTS

author: Douglas Trujillo
date: 2010-06-15 23:51:57.000000000

Uploaded patch set 2.

-------------------------------------
author: Douglas Trujillo
date: 2010-06-15 23:53:31.000000000

Patch Set 2: I would prefer that you didn't submit this

rebased to current master to make it runnable from maven

When running the ui tests from maven, I hit the following error:

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.eclipse.egit.ui.wizards.clone.GitCloneWizardTest
log4j:WARN No appenders could be found for logger (org.eclipse.swtbot.swt.finder.matchers.AbstractMatcher).
log4j:WARN Please initialize the log4j system properly.
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 89.407 sec
Running org.eclipse.egit.ui.common.EGitTestCase
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec <<< FAILURE!
initializationError(org.eclipse.egit.ui.common.EGitTestCase)  Time elapsed: 0 sec  <<< ERROR!
java.lang.Exception: No runnable methods
        at org.junit.runners.BlockJUnit4ClassRunner.validateInstanceMethods(BlockJUnit4ClassRunner.java:171)
        at org.junit.runners.BlockJUnit4ClassRunner.collectInitializationErrors(BlockJUnit4ClassRunner.java:115)
        at org.junit.runners.ParentRunner.validate(ParentRunner.java:269)
        at org.junit.runners.ParentRunner.<init>(ParentRunner.java:66)
        at org.junit.runners.BlockJUnit4ClassRunner.<init>(BlockJUnit4ClassRunner.java:59)
        at org.eclipse.swtbot.swt.finder.junit.SWTBotJunit4ClassRunner.<init>(SWTBotJunit4ClassRunner.java:46)
        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
        at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
        at org.junit.internal.builders.AnnotatedBuilder.buildRunner(AnnotatedBuilder.java:31)
        at org.junit.internal.builders.AnnotatedBuilder.runnerForClass(AnnotatedBuilder.java:24)
        at org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:57)
        at org.junit.internal.builders.AllDefaultPossibilitiesBuilder.runnerForClass(AllDefaultPossibilitiesBuilder.java:29)
        at org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:57)
        at org.junit.internal.requests.ClassRequest.getRunner(ClassRequest.java:24)
        at org.apache.maven.surefire.junit4.JUnit4TestSet.<init>(JUnit4TestSet.java:45)
        at org.apache.maven.surefire.junit4.JUnit4DirectoryTestSuite.createTestSet(JUnit4DirectoryTestSuite.java:56)
        at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.locateTestSets(AbstractDirectoryTestSuite.java:96)
        at org.apache.maven.surefire.Surefire.createSuiteFromDefinition(Surefire.java:209)
        at org.apache.maven.surefire.Surefire.run(Surefire.java:156)
        at org.codehaus.tycho.surefire.osgibooter.OsgiSurefireBooter.run(OsgiSurefireBooter.java:75)
        at org.codehaus.tycho.surefire.osgibooter.AbstractUITestApplication.runTests(AbstractUITestApplication.java:34)
        at org.eclipse.ui.internal.testing.WorkbenchTestable$1.run(WorkbenchTestable.java:71)
        at java.lang.Thread.run(Thread.java:619)

Running org.eclipse.egit.ui.wizards.share.SharingWizardTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.5 sec

Results :

Tests in error:
  initializationError(org.eclipse.egit.ui.common.EGitTestCase)

Tests run: 7, Failures: 0, Errors: 1, Skipped: 0

-------------------------------------
