DESCRIPTION

Move method which can be reused to CompareUtils

Change-Id: I6f334cb184bda60b57da65e38731c0a81ffeeaa8


COMMENTS

author: Rocco Fowler
date: 2012-11-14 16:08:50.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2012-11-14 16:08:57.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/3622/ 

-------------------------------------
author: Brenden Conley
date: 2012-11-14 16:27:11.000000000

Patch Set 2: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/egit.gerrit/3622/ : SUCCESS

-------------------------------------
author: Douglas Trujillo
date: 2012-11-14 22:31:40.000000000

Patch Set 2: I would prefer that you didn't submit this

(4 inline comments)



Line:687, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/CompareUtils.java -> can we find a better name e.g. canDirectlyOpenInCompare(IFile) ?

Line:690, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/CompareUtils.java -> s/change/chance/

Line:694, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/CompareUtils.java -> s/one/on/

Line:706, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/CompareUtils.java -> style nit: we don't use braces around single line blocks

-------------------------------------
author: Gerrit Johnathan Pham
date: 2012-12-21 00:49:55.000000000

Change could not be merged because of a missing dependency.

The following changes must also be submitted:

* Id113b941afa44109b899c17957baa053bd75158f
* I69c3e36b74f8eee7755a55ec9f8f4cc42149fef7


-------------------------------------
author: Gerrit Johnathan Pham
date: 2012-12-21 01:08:17.000000000

Change could not be merged because of a missing dependency.

-------------------------------------
author: Gerrit Johnathan Pham
date: 2012-12-21 09:05:45.000000000

Change could not be merged because of a missing dependency.

-------------------------------------
author: Gerrit Johnathan Pham
date: 2012-12-21 19:59:25.000000000

Change could not be merged because of a missing dependency.

The following changes must also be submitted:

* Id113b941afa44109b899c17957baa053bd75158f
* I69c3e36b74f8eee7755a55ec9f8f4cc42149fef7


-------------------------------------
author: Gerrit Johnathan Pham
date: 2012-12-22 14:02:51.000000000

Change could not be merged because of a missing dependency.

-------------------------------------
author: Gerrit Johnathan Pham
date: 2012-12-24 13:27:43.000000000

Change cannot be merged due to unsatisfiable dependencies.

The following dependency errors were found:

* Depends on patch set 7 of Id113b941, however the current patch set is 8.
* Depends on commit 13819b82c7213e73f569b4e4843b52f3881362e0 which has no change associated with it.

Please rebase the change and upload a replacement commit.

-------------------------------------
author: Gerrit Johnathan Pham
date: 2012-12-24 14:02:33.000000000

Change cannot be merged due to unsatisfiable dependencies.

The following dependency errors were found:

* Depends on patch set 7 of Id113b941, however the current patch set is 8.
* Depends on commit 13819b82c7213e73f569b4e4843b52f3881362e0 which has no change associated with it.

Please rebase the change and upload a replacement commit.

-------------------------------------
author: Gerrit Johnathan Pham
date: 2012-12-25 16:55:47.000000000

Change cannot be merged due to unsatisfiable dependencies.

The following dependency errors were found:

* Depends on patch set 7 of Id113b941, however the current patch set is 8.
* Depends on commit 13819b82c7213e73f569b4e4843b52f3881362e0 which has no change associated with it.

Please rebase the change and upload a replacement commit.

-------------------------------------
