DESCRIPTION

Improve search implementation in RepositorySearchDialog

- use NIO FileVisitor to search repositories
- should be faster than the old approach
- follow symlinks
- update path of currently scanned directory in UI at max 10 times/sec
- sort list of found repository paths in natural order

Change-Id: Ib4487b4b89d5fb79cc0487f6652b94d780de7902
Signed-off-by: Douglas Trujillo xxx@xxx.xxx


COMMENTS

author: Douglas Trujillo
date: 2016-12-13 12:15:11.000000000

Uploaded patch set 3: Patch Set 2 was rebased.

-------------------------------------
author: Brenden Conley
date: 2016-12-13 12:15:18.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/9364/

-------------------------------------
author: Brenden Conley
date: 2016-12-13 12:22:50.000000000

Patch Set 3: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit.gerrit/9364/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2016-12-13 12:28:43.000000000

Patch Set 3: -Verified

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/9365/

-------------------------------------
author: Brenden Conley
date: 2016-12-13 12:52:01.000000000

Patch Set 3: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit.gerrit/9365/ : UNSTABLE

-------------------------------------
author: Brenden Conley
date: 2016-12-13 13:01:41.000000000

Patch Set 3: -Code-Review

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/9366/

-------------------------------------
author: Brenden Conley
date: 2016-12-13 13:25:49.000000000

Patch Set 3: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit.gerrit/9366/ : UNSTABLE

-------------------------------------
author: Alayna Houston
date: 2016-12-13 14:21:18.000000000

Patch Set 3:

(3 comments)

Line:447, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java -> This check appears to exist only to avoid warnings xxx@xxx.xxx on suppressed()? But if d indeed was null, resolve() would already have thrown an NPE.

Move the check to before updateMonitor(), and xxx@xxx.xxx annotations to updateMonitor() and resolve().

Line:478, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java xxx@xxx.xxx Path

Line:495, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java -> When was this introduced? I think it's pretty recent. Won't work on earlier Eclipses. Are we still supporting back to Juno (Eclipse 4.2)?

-------------------------------------
author: Douglas Trujillo
date: 2016-12-14 00:13:41.000000000

Patch Set 3:

(3 comments)

Line:447, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java -> Done

Line:478, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java -> Done

Line:495, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java -> Done

-------------------------------------
author: Gerrit Johnathan Pham
date: 2016-12-17 23:14:04.000000000

Change has been successfully merged into the git repository by Douglas Trujillo

-------------------------------------
