DESCRIPTION

Replace use of deprecated SubProgressMonitor with SubMonitor

Change-Id: Id9e0abdfbfc96a6c92dc136cac8e41db5d33d548
Signed-off-by: Douglas Trujillo xxx@xxx.xxx

COMMENTS

author: Douglas Trujillo
date: 2016-12-06 00:15:32.000000000

Uploaded patch set 2: Patch Set 1 was rebased.

-------------------------------------
author: Brenden Conley
date: 2016-12-06 01:01:54.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/9325/

-------------------------------------
author: Brenden Conley
date: 2016-12-06 01:25:34.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/9325/ : SUCCESS

-------------------------------------
author: Alayna Houston
date: 2016-12-14 08:04:01.000000000

Patch Set 2: Code-Review-1

(11 comments)

Line:48, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/SubmoduleSyncCommand.java -> SubMonitor progress = SubMonitor.convert(monitor,repoPaths.size());

Line:57, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/SubmoduleSyncCommand.java -> op.execute(progress.newChild(1));

Line:172, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/operations/GitScopeUtil.java -> SubMonitor progress = SubMonitor.convert(monitor,2); then pass on progress.newChild(1) twice.

Line:98, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/ProjectUtils.java -> I don't think one should convert the same monitor multiple times. Use

  SubMonitor progress = SubMonitor.convert(actMonitor, projectsToCreate.size() * 2 + 1);

at the top and then use only progress, not actMonitor, and use progress.newChild(1) here and below.

Line:128, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/ProjectUtils.java -> I think using a SubMonitor as indicated above we wouldn't need this done() call anymore, nor the try-finally.

Line:148, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/ProjectUtils.java -> SubMonitor progress = SubMonitor.convert(monitor,2);

Line:155, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/ProjectUtils.java -> progress.newChild(1);

Line:156, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/ProjectUtils.java -> progress.newChild(1);

Line:182, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/ProjectUtils.java -> Same here. Convert to SubMonitor once, then use newChild().

Line:113, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/SubmoduleUpdateCommand.java -> See comments on SubmoduleUpdateOperation.

Line:276, org.eclipse.egit.core/src/org/eclipse/egit/core/GitMoveDeleteHook.java -> Since this is the only place where this method uses the monitor at all, just pass it through. But the callers should properly use SubMonitor.convert() and newChild() as appropriate.

-------------------------------------
author: Douglas Trujillo
date: 2016-12-14 17:26:17.000000000

Patch Set 2:

(11 comments)

Line:48, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/SubmoduleSyncCommand.java -> Done

Line:57, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/SubmoduleSyncCommand.java -> Done

Line:172, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/operations/GitScopeUtil.java -> Done

Line:98, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/ProjectUtils.java -> Done

Line:128, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/ProjectUtils.java -> Done

Line:148, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/ProjectUtils.java -> Done

Line:155, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/ProjectUtils.java -> Done

Line:156, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/ProjectUtils.java -> Done

Line:182, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/ProjectUtils.java -> Done

Line:113, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/SubmoduleUpdateCommand.java -> Done

Line:276, org.eclipse.egit.core/src/org/eclipse/egit/core/GitMoveDeleteHook.java -> Done

-------------------------------------
author: Gerrit Johnathan Pham
date: 2016-12-16 17:50:38.000000000

Change has been successfully merged into the git repository by Douglas Trujillo

-------------------------------------
