DESCRIPTION

Correctly determine selected resource in multi-page editors

SelectionUtils.getSelection() must in this case use the IEditorInput of
the currently active nested text editor, if any.

Bug: 506858
Change-Id: I3f050e7f6d1823bc3f874bd84d54a2a43b973418
Signed-off-by: Alayna Houston xxx@xxx.xxx

COMMENTS

author: Alayna Houston
date: 2016-11-01 22:32:21.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-11-01 22:45:16.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/9237/

-------------------------------------
author: Brenden Conley
date: 2016-11-01 23:09:16.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/9237/ : SUCCESS

-------------------------------------
author: Douglas Trujillo
date: 2016-11-01 23:44:22.000000000

Patch Set 1:

I tried this on a clone of the EGit repository, trying to "Show Revision Information" on MANIFEST.MF of org.eclipse.egit.core hits the following exception

org.eclipse.core.internal.resources.ResourceException: The resource tree is locked for modifications.
	at org.eclipse.core.internal.resources.WorkManager.checkIn(WorkManager.java:119)
	at org.eclipse.core.internal.resources.Workspace.prepareOperation(Workspace.java:2188)
	at org.eclipse.core.internal.resources.Resource.touch(Resource.java:1797)
	at org.eclipse.pde.internal.core.builders.FeatureRebuilder.touchFeatures(FeatureRebuilder.java:81)
	at org.eclipse.pde.internal.core.builders.FeatureRebuilder.modelsChanged(FeatureRebuilder.java:58)
	at org.eclipse.pde.internal.core.PluginModelManager.fireDelta(PluginModelManager.java:357)
	at org.eclipse.pde.internal.core.PluginModelManager.modelsChanged(PluginModelManager.java:257)
	at org.eclipse.pde.internal.core.AbstractModelManager.fireModelProviderEvent(AbstractModelManager.java:34)
	at org.eclipse.pde.internal.core.WorkspaceModelManager.createAndFireEvent(WorkspaceModelManager.java:259)
	at org.eclipse.pde.internal.core.WorkspacePluginModelManager.createAndFireEvent(WorkspacePluginModelManager.java:481)
	at org.eclipse.pde.internal.core.WorkspaceModelManager.processModelChanges(WorkspaceModelManager.java:231)
	at org.eclipse.pde.internal.core.WorkspaceModelManager.processModelChanges(WorkspaceModelManager.java:193)
	at org.eclipse.pde.internal.core.WorkspacePluginModelManager.processModelChanges(WorkspacePluginModelManager.java:470)
	at org.eclipse.pde.internal.core.WorkspaceModelManager.resourceChanged(WorkspaceModelManager.java:113)
	at org.eclipse.jdt.internal.core.DeltaProcessingState$1.run(DeltaProcessingState.java:472)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.jdt.internal.core.DeltaProcessingState.resourceChanged(DeltaProcessingState.java:467)
	at org.eclipse.core.internal.events.NotificationManager$1.run(NotificationManager.java:299)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.core.internal.events.NotificationManager.notify(NotificationManager.java:289)
	at org.eclipse.core.internal.events.NotificationManager.broadcastChanges(NotificationManager.java:152)
	at org.eclipse.core.internal.resources.Workspace.broadcastPostChange(Workspace.java:374)
	at org.eclipse.core.internal.resources.Workspace.endOperation(Workspace.java:1469)
	at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:46)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

-------------------------------------
author: Douglas Trujillo
date: 2016-11-01 23:45:37.000000000

Patch Set 1:

> I tried this on a clone of the EGit repository, trying to "Show
 > Revision Information" on MANIFEST.MF of org.eclipse.egit.core hits
 > the following exception
 > 
 > org.eclipse.core.internal.resources.ResourceException: The resource
 > tree is locked for modifications.
 > at org.eclipse.core.internal.resources.WorkManager.checkIn(WorkManager.java:119)
 > at org.eclipse.core.internal.resources.Workspace.prepareOperation(Workspace.java:2188)
 > at org.eclipse.core.internal.resources.Resource.touch(Resource.java:1797)
 > at org.eclipse.pde.internal.core.builders.FeatureRebuilder.touchFeatures(FeatureRebuilder.java:81)
 > at org.eclipse.pde.internal.core.builders.FeatureRebuilder.modelsChanged(FeatureRebuilder.java:58)
 > at org.eclipse.pde.internal.core.PluginModelManager.fireDelta(PluginModelManager.java:357)
 > at org.eclipse.pde.internal.core.PluginModelManager.modelsChanged(PluginModelManager.java:257)
 > at org.eclipse.pde.internal.core.AbstractModelManager.fireModelProviderEvent(AbstractModelManager.java:34)
 > at org.eclipse.pde.internal.core.WorkspaceModelManager.createAndFireEvent(WorkspaceModelManager.java:259)
 > at org.eclipse.pde.internal.core.WorkspacePluginModelManager.createAndFireEvent(WorkspacePluginModelManager.java:481)
 > at org.eclipse.pde.internal.core.WorkspaceModelManager.processModelChanges(WorkspaceModelManager.java:231)
 > at org.eclipse.pde.internal.core.WorkspaceModelManager.processModelChanges(WorkspaceModelManager.java:193)
 > at org.eclipse.pde.internal.core.WorkspacePluginModelManager.processModelChanges(WorkspacePluginModelManager.java:470)
 > at org.eclipse.pde.internal.core.WorkspaceModelManager.resourceChanged(WorkspaceModelManager.java:113)
 > at org.eclipse.jdt.internal.core.DeltaProcessingState$1.run(DeltaProcessingState.java:472)
 > at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
 > at org.eclipse.jdt.internal.core.DeltaProcessingState.resourceChanged(DeltaProcessingState.java:467)
 > at org.eclipse.core.internal.events.NotificationManager$1.run(NotificationManager.java:299)
 > at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
 > at org.eclipse.core.internal.events.NotificationManager.notify(NotificationManager.java:289)
 > at org.eclipse.core.internal.events.NotificationManager.broadcastChanges(NotificationManager.java:152)
 > at org.eclipse.core.internal.resources.Workspace.broadcastPostChange(Workspace.java:374)
 > at org.eclipse.core.internal.resources.Workspace.endOperation(Workspace.java:1469)
 > at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:46)
 > at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

and no blame is shown

-------------------------------------
author: Alayna Houston
date: 2016-11-01 23:53:47.000000000

Patch Set 1:

> > I tried this on a clone of the EGit repository, trying to "Show
 > > Revision Information" on MANIFEST.MF of org.eclipse.egit.core
 > hits
 > > the following exception
 > >
 > > org.eclipse.core.internal.resources.ResourceException: The
 > resource
 > > tree is locked for modifications.
 > > at org.eclipse.core.internal.resources.WorkManager.checkIn(WorkManager.java:119)
 > > at org.eclipse.core.internal.resources.Workspace.prepareOperation(Workspace.java:2188)
 > > at org.eclipse.core.internal.resources.Resource.touch(Resource.java:1797)
 > > at org.eclipse.pde.internal.core.builders.FeatureRebuilder.touchFeatures(FeatureRebuilder.java:81)
 > > at org.eclipse.pde.internal.core.builders.FeatureRebuilder.modelsChanged(FeatureRebuilder.java:58)
 > > at org.eclipse.pde.internal.core.PluginModelManager.fireDelta(PluginModelManager.java:357)
 > > at org.eclipse.pde.internal.core.PluginModelManager.modelsChanged(PluginModelManager.java:257)
 > > at org.eclipse.pde.internal.core.AbstractModelManager.fireModelProviderEvent(AbstractModelManager.java:34)
 > > at org.eclipse.pde.internal.core.WorkspaceModelManager.createAndFireEvent(WorkspaceModelManager.java:259)
 > > at org.eclipse.pde.internal.core.WorkspacePluginModelManager.createAndFireEvent(WorkspacePluginModelManager.java:481)
 > > at org.eclipse.pde.internal.core.WorkspaceModelManager.processModelChanges(WorkspaceModelManager.java:231)
 > > at org.eclipse.pde.internal.core.WorkspaceModelManager.processModelChanges(WorkspaceModelManager.java:193)
 > > at org.eclipse.pde.internal.core.WorkspacePluginModelManager.processModelChanges(WorkspacePluginModelManager.java:470)
 > > at org.eclipse.pde.internal.core.WorkspaceModelManager.resourceChanged(WorkspaceModelManager.java:113)
 > > at org.eclipse.jdt.internal.core.DeltaProcessingState$1.run(DeltaProcessingState.java:472)
 > > at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
 > > at org.eclipse.jdt.internal.core.DeltaProcessingState.resourceChanged(DeltaProcessingState.java:467)
 > > at org.eclipse.core.internal.events.NotificationManager$1.run(NotificationManager.java:299)
 > > at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
 > > at org.eclipse.core.internal.events.NotificationManager.notify(NotificationManager.java:289)
 > > at org.eclipse.core.internal.events.NotificationManager.broadcastChanges(NotificationManager.java:152)
 > > at org.eclipse.core.internal.resources.Workspace.broadcastPostChange(Workspace.java:374)
 > > at org.eclipse.core.internal.resources.Workspace.endOperation(Workspace.java:1469)
 > > at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:46)
 > > at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
 > 
 > and no blame is shown

1. I cannot reproduce this. This exception looks completely unrelated.
2. Don't try with blame. It will fail anyway due to bug 506841. Try with compare or replace with.
3. If you want to try with blame, re-base this onto https://git.eclipse.org/r/#/c/84299/

-------------------------------------
author: Gerrit Johnathan Pham
date: 2016-11-02 09:02:14.000000000

Change has been successfully merged into the git repository by Alayna Houston

-------------------------------------
