DESCRIPTION

Bug 501799: Click on search result causes EGit to stat the repository
directory

Change-Id: I45efcbbd54bbfbb1e9acf2c19371cba2c9c0d1e4
Signed-off-by: <Kassandra Newman>

COMMENTS

author: Marisol Rowland
date: 2016-09-23 14:04:57.000000000

Patch Set 2: Published edit on patch set 1

-------------------------------------
author: Brenden Conley
date: 2016-09-23 14:05:35.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/9092/

-------------------------------------
author: Brenden Conley
date: 2016-09-23 14:55:40.000000000

Patch Set 2: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit.gerrit/9092/ : ABORTED

-------------------------------------
author: Alayna Houston
date: 2016-09-23 18:43:24.000000000

Patch Set 2: Code-Review-1

(8 comments)

Line:207, org.eclipse.egit.core/src/org/eclipse/egit/core/internal/indexdiff/GitResourceDeltaVisitor.java -> This should be proper javadoc.

Line:140, org.eclipse.egit.core.test/src/org/eclipse/egit/core/internal/indexdiff/IndexDiffCacheTest.java -> Why this removal?

Line:1, org.eclipse.egit.core/src/org/eclipse/egit/core/internal/indexdiff/SkipNotInterestingDeltaVisitor.java -> Missing copyright header.

Line:9, org.eclipse.egit.core/src/org/eclipse/egit/core/internal/indexdiff/SkipNotInterestingDeltaVisitor.java -> Capital 'W'

Line:12, org.eclipse.egit.core/src/org/eclipse/egit/core/internal/indexdiff/SkipNotInterestingDeltaVisitor.java -> We don't xxx@xxx.xxx tags.

Line:20, org.eclipse.egit.core/src/org/eclipse/egit/core/internal/indexdiff/SkipNotInterestingDeltaVisitor.java -> To really short-circuit do here

  if (atLeastOneInterestingDelta) {
    return false;
  }

Line:32, org.eclipse.egit.core/src/org/eclipse/egit/core/internal/indexdiff/SkipNotInterestingDeltaVisitor.java -> Superfluous if-statement

Line:699, org.eclipse.egit.core/src/org/eclipse/egit/core/internal/indexdiff/IndexDiffCacheEntry.java -> This approach will need careful performance tests on large workspaces. (On a machine with a hard disk in good working order :-)) I'm especially worried about post-build events that may have many "uninteresting changes" (marker changes).

-------------------------------------
author: Alayna Houston
date: 2016-09-23 18:47:58.000000000

Patch Set 2:

(1 comment)

Line:11, /COMMIT_MSG -> See http://wiki.eclipse.org/EGit/Contributor_Guide#Commit_message_guidelines for the commit message format we use for EGit.

Basically:

  Ignore uninteresting changes up-front in IndexDiffCacheEntry

  Description here: why & how

  Bug: 501799
  Change-Id: ...
  Signed-off-by: ...

-------------------------------------
author: Alayna Houston
date: 2016-09-23 18:51:11.000000000

Patch Set 2:

(1 comment)

Line:4, /COMMIT_MSG -> Why not use your real name as you did above?

-------------------------------------
author: Gerrit Johnathan Pham
date: 2016-10-11 16:47:52.000000000

Change has been successfully merged into the git repository by Alayna Houston

-------------------------------------
