DESCRIPTION

Introduce "General" group to cleanup layout of "Committing" preferences

Change-Id: Icf8a713b7f0e9e22bc96f3c454ca22e1c8fc195a
Signed-off-by: Douglas Trujillo xxx@xxx.xxx

COMMENTS

author: Douglas Trujillo
date: 2016-08-15 12:24:38.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-08-15 12:24:44.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/8973/

-------------------------------------
author: Brenden Conley
date: 2016-08-15 12:49:17.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/8973/ : SUCCESS

-------------------------------------
author: Alayna Houston
date: 2016-08-15 13:12:58.000000000

Patch Set 1:

(4 comments)

Line:75, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/preferences/CommittingPreferencePage.java -> For the other groups, updateMargins() is called. Needed? If so, also for this group?

Line:105, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/preferences/CommittingPreferencePage.java -> Hadn't noticed we had tooltips here. Do we want tooltips on useStagingView and on autoStage, too?

Line:214, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/preferences/CommittingPreferencePage.java -> Shouldn't this be generalGroup now?

Line:228, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/preferences/CommittingPreferencePage.java -> Same here.

-------------------------------------
author: Douglas Trujillo
date: 2016-08-15 21:58:08.000000000

Patch Set 1:

(4 comments)

Line:75, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/preferences/CommittingPreferencePage.java -> Done

Line:105, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/preferences/CommittingPreferencePage.java -> I think we don't need tooltips

Line:214, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/preferences/CommittingPreferencePage.java -> Done

Line:228, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/preferences/CommittingPreferencePage.java -> Done

-------------------------------------
author: Gerrit Johnathan Pham
date: 2016-08-16 22:43:09.000000000

Change has been successfully merged into the git repository by Douglas Trujillo

-------------------------------------
