DESCRIPTION

Auto-stage selected files on "Commit..." when staging view is used

* New preference UiPreferences.AUTO_STAGE_ON_COMMIT for auto-staging
  when the staging view is used. Default is true.
* Change some private operations from CommitUI to public static utility
  operations, so they can be re-used.
* Add auto-staging functionality in CommitActionHandler

Auto-staging honors the UiPreferences.COMMIT_DIALOG_INCLUDE_UNTRACKED
setting. Staging occurs in a background job.

Bug: 497574
Change-Id: I5273400b602e1e4681fe0be6ed34b8fefef795a5
Signed-off-by: Alayna Houston xxx@xxx.xxx

COMMENTS

author: Alayna Houston
date: 2016-08-07 12:43:42.000000000

Uploaded patch set 4.

-------------------------------------
author: Brenden Conley
date: 2016-08-07 12:43:48.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/8947/

-------------------------------------
author: Brenden Conley
date: 2016-08-07 13:09:14.000000000

Patch Set 4: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/8947/ : SUCCESS

-------------------------------------
author: Rocco Fowler
date: 2016-08-09 18:47:17.000000000

Patch Set 4:

(2 comments)

Nice!

Line:170, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/CommitActionHandler.java -> Should there be a test that the right files are staged?

Line:1048, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/uitext.properties -> Strictly following the implementation it should read: "Automatically stage selected resources on commit when using Staging View".

-------------------------------------
author: Douglas Trujillo
date: 2016-08-10 07:21:49.000000000

Patch Set 4: Code-Review+2

(1 comment)

Line:1048, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/uitext.properties -> I think that's clear from the context, this option is shown nested under the preference which configures if staging view should be used to commit instead of commit dialog. If this option is off (commit uses commit dialog) the auto-staging option is greyed out

-------------------------------------
author: Alayna Houston
date: 2016-08-11 18:18:57.000000000

Patch Set 4:

(1 comment)

Line:170, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/CommitActionHandler.java -> Minimal tests added in PS 5.

-------------------------------------
author: Gerrit Johnathan Pham
date: 2016-08-15 11:54:39.000000000

Change has been successfully merged into the git repository by Douglas Trujillo

-------------------------------------
