DESCRIPTION

Suppress bare repositories in RepositorySearchDialog

When a bare repository is selected in the GitSelectRepositoryPage, the
import wizard throws and reports multiple NoWorkTreeExceptions.

Since a bare repository has no working tree, one cannot import from a
bare repository. Therefore, suppress bare repositories in the
RepositorySearchDialog which is used to add repositories to the
GitSelectRepositoryPage when used from the GitImportWizard. The
user thus cannot select a bare repository.

Bug: 495930
Change-Id: I6102eadd19e07ae47cf48ce0bf24ef6e64a44749
Signed-off-by: Douglas Trujillo xxx@xxx.xxx

COMMENTS

author: Douglas Trujillo
date: 2016-07-06 13:36:19.000000000

Uploaded patch set 4.

-------------------------------------
author: Brenden Conley
date: 2016-07-06 13:36:25.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/8807/

-------------------------------------
author: Alayna Houston
date: 2016-07-06 13:51:39.000000000

Patch Set 4:

(4 comments)

Looks like that was only half of the logic switch.

Line:53, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/AddCommand.java -> True, now.

Line:187, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java -> Since the logic switch, this should be true (former behavior).

Line:28, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchWizard.java -> rename to allowBare, too.

Line:177, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitSelectRepositoryPage.java -> Since you switched the logic in the dialog, this should now be simply allowBare.

-------------------------------------
author: Douglas Trujillo
date: 2016-07-06 13:56:30.000000000

Patch Set 4:

(4 comments)

Line:53, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/AddCommand.java -> Done

Line:187, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java -> Done

Line:28, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchWizard.java -> Done

Line:177, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitSelectRepositoryPage.java -> Done

-------------------------------------
author: Brenden Conley
date: 2016-07-06 14:09:06.000000000

Patch Set 4: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit.gerrit/8807/ : UNSTABLE

-------------------------------------
author: Gerrit Johnathan Pham
date: 2016-07-06 20:55:03.000000000

Change has been successfully merged into the git repository by Douglas Trujillo

-------------------------------------
