DESCRIPTION

Suppress bare repositories in RepositorySearchDialog

When a bare repository is selected in the GitSelectRepositoryPage, the
import wizard throws and reports multiple NoWorkTreeExceptions.

Since a bare repository has no working tree, one cannot import from a
bare repository. Therefore, suppress bare repositories in the
RepositorySearchDialog which is used to add repositories to the
GitSelectRepositoryPage when used from the GitImportWizard. The
user thus cannot select a bare repository.

Bug: 495930
Change-Id: I6102eadd19e07ae47cf48ce0bf24ef6e64a44749
Signed-off-by: Douglas Trujillo xxx@xxx.xxx

COMMENTS

author: Douglas Trujillo
date: 2016-07-05 22:31:23.000000000

Uploaded patch set 3.

-------------------------------------
author: Douglas Trujillo
date: 2016-07-05 22:32:26.000000000

Patch Set 3:

you are right, then let's use both patches

-------------------------------------
author: Brenden Conley
date: 2016-07-05 23:09:44.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/8806/

-------------------------------------
author: Brenden Conley
date: 2016-07-05 23:39:12.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/8806/ : SUCCESS

-------------------------------------
author: Alayna Houston
date: 2016-07-06 11:02:36.000000000

Patch Set 3:

(3 comments)

Line:448, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java -> Sytyle nit: line 438 uses Constants.DOT_GIT.equals(...). Doesn't matter much here since getName() will never be null, but let's use a consistent style.

Line:449, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java -> Needed? On line 430, it's just root.equals(resolved). Don't know which is better, but should use the same.

Line:177, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitSelectRepositoryPage.java -> !allowBare

Also, I had used allowBare, while you used suppressBare. We should harmonize that and use the same logic.

-------------------------------------
author: Douglas Trujillo
date: 2016-07-06 13:55:27.000000000

Patch Set 3:

(3 comments)

Line:448, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java -> Done

Line:449, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositorySearchDialog.java -> I think it's more accurate, now also use it in line 430

Line:177, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitSelectRepositoryPage.java -> Done

-------------------------------------
author: Gerrit Johnathan Pham
date: 2016-07-06 20:55:03.000000000

Change has been successfully merged into the git repository by Douglas Trujillo

-------------------------------------
